-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the string that clears the console. #2071
Conversation
facebook#1914 I've tested it with Windows 10 and 7, node versions from ~5.0.0 up to 7.7.0. Didn't managed to test it on 8 but it should be fine.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
I'm pretty sure |
It's probably not relevant any more. It worked for me without |
In the beginning we only used Eventually we ended up copying Jest via jestjs/jest#2230. Jest's latest sequence is https://github.com/facebook/jest/blob/master/packages/jest-cli/src/constants.js#L15, which appears identical to what we're still doing. We can try |
Add windows specific string for clearing the console.
It seems to work with In windows 10 it clears the console with Git Bash, CMD and Powershell. |
Am I correct that the current string fails in GitBash but works in other environments? |
Yes. |
I’ll test this later today. |
We’ll need a matching PR to Jest. |
This does seem to work better on a new Windows laptop I'm using. I don't understand why though. It even works in PowerShell but old sequence doesn't (with PowerShell too) on my new Windows laptop. How is this possible? Could some new Windows 10 versions break the old sequence? |
Probably just another weird thing of windows, the original sequence stopped working for me after an update. |
Can you send this PR to Jest too? http://github.com/facebook/jest |
Never mind, I sent jestjs/jest#5251. |
This is out in |
* Update the string that clears the console. facebook#1914 I've tested it with Windows 10 and 7, node versions from ~5.0.0 up to 7.7.0. Didn't managed to test it on 8 but it should be fine. * Update windows string Add windows specific string for clearing the console.
#1914
I've tested it with Windows 10 and 7, node versions from ~5.0.0 up to 7.7.0.
Didn't managed to test it on 8 but it should work to.
Before
After