Add option for setting webpack watch option polling #1459
Conversation
The motivation was for enabling using a virtualbox virtual machine with hot code reloading.
The rsync and normal file synchronisation provided by vagrant 1.9.1 and 5.1.14 does not
trigger webpack to hot reload the code. By being able to provide an optional environment
variable hot reloading works with vagrant/virtualbox. For example:
$ WEBPACK_WATCH_POLL=1000 npm start
Problem and solution discussed by others here:
http://stackoverflow.com/questions/34937294/how-to-enable-hot-reloading-via-shared-folders-with-vagrant-vm#comment64629465_34937378
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
This is not the best interface, and this pull request also does not include documentation, so am very happy to review / rewrite or ultimately discuss and accept / reject this proposal. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Is there any way we can detect this instead of adding a configuration option? |
|
@gaearon ideally webpack would detect the change to the file and or vagrant/virtualbox would trigger the correct hook on syncing the file. I'll try to dig into it next week to see where the problem might be. Any pointers / advice from your side would be appreciated. And yes I agree it would be preferable for webpack to detect the file change correctly as opposed to adding this config option. |
|
Please see https://github.com/facebookincubator/create-react-app/issues/1049#issuecomment-261738388—let's just get it into chokidar and then it will work for every tool instead. |
The motivation was for enabling using a virtualbox virtual machine with hot code reloading.
The rsync and normal file synchronisation provided by vagrant 1.9.1 and 5.1.14 does not
trigger webpack to hot reload the code. By being able to provide an optional environment
variable hot reloading works with vagrant/virtualbox. For example:
Problem and solution discussed by others here:
http://stackoverflow.com/questions/34937294/how-to-enable-hot-reloading-via-shared-folders-with-vagrant-vm#comment64629465_34937378