Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to ellipses #144

Merged
merged 3 commits into from
Jul 24, 2016
Merged

updating to ellipses #144

merged 3 commits into from
Jul 24, 2016

Conversation

KrishMunot
Copy link
Contributor

No description provided.

@ghost ghost added the CLA Signed label Jul 23, 2016
@@ -80,7 +80,7 @@ It correctly bundles React in production mode and optimizes the build for the be
The build is minified and the filenames include the hashes.<br>
Your app is ready to be deployed!

## How Do I?...
## How Do I..?
Copy link
Contributor

@gaearon gaearon Jul 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be more correct: …?
Can you use this please?

(note the ellipsis instead of three dots)

@@ -80,7 +80,7 @@ It correctly bundles React in production mode and optimizes the build for the be
The build is minified and the filenames include the hashes.<br>
Your app is ready to be deployed!

## How Do I?...
## How Do I...?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey can you change the ## How Do I...? to ## How Do I…?

The second uses the ellipses character rather than 3 dots :)

You can just copy the character from this comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha! Thanks! I didn't notice that.
I updated the commit :)

@KrishMunot KrishMunot changed the title readjust the dots updating to ellipses Jul 24, 2016
@eanplatter
Copy link
Contributor

👍

@ghost ghost added the CLA Signed label Jul 24, 2016
@eanplatter eanplatter merged commit f82ecad into facebook:master Jul 24, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants