Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a fairly easy change of just a few lines to allow the buildscript to interpret the NODE_ENV variable for the environment. if security is your concern, i could also use a different env variable like REACT_NODE_ENV_YES_IM_SURE.
i and many other people have needed this feature for almost 8 years now as evident by this issue #790
it boggles the mind how this is hardcoded to production builds. not every stack is built in a way that enables testing with npm start and then deployment with npm run build. there has to be a way to enable dev/staging builds even if it requires setting silly env vars like mentioned above
please feedback if you want me to change the env var name