Add a prompt around the graduate script and change it from graduate to eject. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| console.log('Close one! Eject aborted.') | ||
| } | ||
| }); |
There was a problem hiding this comment.
I wasn't exactly sure if this was a faux pas to put custom script code in the bin/. If it is I can move it into the script itself. >.<
There was a problem hiding this comment.
Can you add this at the beginning of scripts/eject.js and process.exit(1) if the user says no?
There was a problem hiding this comment.
Definitely, rebase inbound.
ghost
added
| @@ -0,0 +1 @@ | |||
| {"name":"omg","version":"0.0.1","private":true} | |||
There was a problem hiding this comment.
dang you're too fast for me :)
|
Yay! Thanks |
vjeux
pushed a commit
that referenced
this pull request
Jul 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the name of the graduate command to "eject" and fixes #9.
It also adds a prompt to the script so that a user doesn't accidentally eject themselves.
Screenshot of the prompt:
