Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version of TypeScript ESLint packages #7555

Closed
lffg opened this issue Aug 17, 2019 · 2 comments
Closed

Incorrect version of TypeScript ESLint packages #7555

lffg opened this issue Aug 17, 2019 · 2 comments

Comments

@lffg
Copy link
Contributor

lffg commented Aug 17, 2019

The problem

In the most recent version of eslint-config-react-app, which gives support to ESLint 6.x, the dependencies versions are incorrect.

If you see in eslint-config-react-app's package.json file, the required ESLint version should be in the 6th major release range:

But in this same dependency tree, we also have the need of @typescript-eslint/parser and @typescript-eslint/eslint-plugin packages, both in the 1.x version range.

The problem is: both @typescript-eslint/parser and @typescript-eslint/eslint-plugin in the 1.x version range (the version that eslint-config-react-app uses) do not support ESLint 6.x. You can it in the following links:

The solution

I suggest that we upgrade @typescript-eslint/parser and @typescript-eslint/eslint-plugin to its latest major release (2.x), which supports ESLint 6.x.

PS: I think that this problem is causing some issues with the create-react-app preflight checks.

@CarsonF
Copy link

CarsonF commented Aug 17, 2019

Duplicate of #7529

@lffg
Copy link
Contributor Author

lffg commented Aug 17, 2019

Whoops! Sorry about that. T_T

@lffg lffg closed this as completed Aug 17, 2019
@lock lock bot locked and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants