Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript-eslint to v2 #7529

Closed
iansu opened this issue Aug 14, 2019 · 2 comments · Fixed by #7540
Closed

Upgrade typescript-eslint to v2 #7529

iansu opened this issue Aug 14, 2019 · 2 comments · Fixed by #7540
Assignees

Comments

@iansu
Copy link
Contributor

iansu commented Aug 14, 2019

v2 supports ESLint 6. However it also includes a number of breaking changes so we need to determine if any of them will impact our users: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v2.0.0

@chibicode
Copy link
Contributor

chibicode commented Aug 14, 2019

@typescript-eslint/no-angle-bracket-type-assertion is deprecated. So we need to change this line:

'@typescript-eslint/no-angle-bracket-type-assertion': 'warn',

It's now called @typescript-eslint/consistent-type-assertions. I believe it can be set as:

{ assertionStyle: 'as', objectLiteralTypeAssertions: 'allow' }

Not so sure about objectLiteralTypeAssertions though. There wasn't any existing rule on our config related to this.

@GLoganDR
Copy link

Is there a release ETA for this? I see it's already been PRed and merged. Great job and thanks, btw! 👍

@lock lock bot locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants