Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make package.json complete #25

Closed
gaearon opened this issue Jul 19, 2016 · 3 comments
Closed

Make package.json complete #25

gaearon opened this issue Jul 19, 2016 · 3 comments
Milestone
0.1.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Jul 19, 2016

Currently missing repository and license fields so npm complains.
Would be good to add other meta information similar to React.

Don’t forget we have two package.jsons so both need to be updated.
@gaearon gaearon added this to the 0.1.0 milestone Jul 19, 2016
@mxstbr
Copy link
Contributor

mxstbr commented Jul 19, 2016

What will the repository be? facebook/create-react-app? (I don't assume it'll stay under facebookincubator)

@lacker
Copy link
Contributor

lacker commented Jul 19, 2016

The plan right now for most new fb open source projects is to launch under facebookincubator and move to the facebook org once it "proves itself". So as long as this repo is facebookincubator the package.json repository field should prob be the same

mxstbr added a commit that referenced this issue Jul 19, 2016
@mxstbr
Add repository and license field to package.json
6281b48 
Ref #25
gaearon pushed a commit that referenced this issue Jul 20, 2016
@mxstbr @gaearon
Add repository and license field to package.json
3dea46d 
Ref #25
@gaearon
Copy link
Contributor Author

gaearon commented Jul 20, 2016

Fixed by 3dea46d and #39.

@gaearon gaearon closed this as completed Jul 20, 2016
stayradiated pushed a commit to stayradiated/create-react-app that referenced this issue Nov 13, 2016
@kitze
Merge pull request facebook#25 from markdalgleish/patch-1
97c1018 
Fix CSS Modules configuration option
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
3 participants
@lacker @gaearon @mxstbr