Temporarily disable Windows in CI (#7773)

facebook · Oct 3, 2019 · e51ea13 · e51ea13
1 parent 7fae307
commit e51ea13
Show file tree

Hide file tree

Showing 5 changed files with 91 additions and 93 deletions.
diff --git a/azure-pipelines-test-job.yml b/azure-pipelines-test-job.yml
@@ -6,35 +6,35 @@ parameters:
   name: ''
   testScript: ''
   configurations:
-    LinuxNode8:    { vmImage: 'ubuntu-16.04',   nodeVersion: 8.x  }
-    LinuxNode10:   { vmImage: 'ubuntu-16.04',   nodeVersion: 10.x }
-    WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
-    WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
-    
+    LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
+    LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
+    # WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
+    # WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
+
 jobs:
-- job: ${{ parameters.name }}
-  strategy:
-    matrix:
-      ${{ insert }}: ${{ parameters.configurations }}
-  pool:
-    vmImage: $(vmImage)
-  steps:
-  - script: |
-      git config --global core.autocrlf false
-      git config --global user.name "Create React App"
-      git config --global user.email "cra@email.com"
-    displayName: 'Initialize Git config'
+  - job: ${{ parameters.name }}
+    strategy:
+      matrix:
+        ${{ insert }}: ${{ parameters.configurations }}
+    pool:
+      vmImage: $(vmImage)
+    steps:
+      - script: |
+          git config --global core.autocrlf false
+          git config --global user.name "Create React App"
+          git config --global user.email "cra@email.com"
+        displayName: 'Initialize Git config'
 
-  - checkout: self
-    path: create-react-app
+      - checkout: self
+        path: create-react-app
 
-  - task: NodeTool@0
-    inputs:
-      versionSpec: $(nodeVersion)
-    displayName: 'Install Node.js'
+      - task: NodeTool@0
+        inputs:
+          versionSpec: $(nodeVersion)
+        displayName: 'Install Node.js'
 
-  - script: yarn --frozen-lockfile
-    displayName: 'Run yarn'
+      - script: yarn --frozen-lockfile
+        displayName: 'Run yarn'
 
-  - bash: ${{ parameters.testScript }}
-    displayName: 'Run tests'
+      - bash: ${{ parameters.testScript }}
+        displayName: 'Run tests'
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -3,7 +3,7 @@
 #
 
 trigger:
-- master
+  - master
 
 variables:
   CI: true
@@ -19,60 +19,60 @@ variables:
 # Simple test suite
 # ******************************************************************************
 jobs:
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: Simple
-    testScript: tasks/e2e-simple.sh
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Simple
+      testScript: tasks/e2e-simple.sh
 
-# ******************************************************************************
-# Installs test suite
-# ******************************************************************************
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: Installs
-    testScript: tasks/e2e-installs.sh
+  # ******************************************************************************
+  # Installs test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Installs
+      testScript: tasks/e2e-installs.sh
 
-# ******************************************************************************
-# Kitchensink test suite
-# ******************************************************************************
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: Kitchensink
-    testScript: tasks/e2e-kitchensink.sh
+  # ******************************************************************************
+  # Kitchensink test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Kitchensink
+      testScript: tasks/e2e-kitchensink.sh
 
-# ******************************************************************************
-# Kitchensink Eject test suite
-# ******************************************************************************
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: KitchensinkEject
-    testScript: tasks/e2e-kitchensink-eject.sh
+  # ******************************************************************************
+  # Kitchensink Eject test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: KitchensinkEject
+      testScript: tasks/e2e-kitchensink-eject.sh
 
-# ******************************************************************************
-# Behavior test suite
-# ******************************************************************************
-- template: azure-pipelines-test-job.yml
-  parameters:
-    name: Behavior
-    testScript: tasks/e2e-behavior.sh
-    configurations:
-      LinuxNode8:    { vmImage: 'ubuntu-16.04',   nodeVersion: 8.x  }
-      LinuxNode10:   { vmImage: 'ubuntu-16.04',   nodeVersion: 10.x }
-      WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
-      WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
-      MacNode8:      { vmImage: 'macOS-10.13',    nodeVersion: 8.x  }
-      MacNode10:     { vmImage: 'macOS-10.13',    nodeVersion: 10.x }
+  # ******************************************************************************
+  # Behavior test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Behavior
+      testScript: tasks/e2e-behavior.sh
+      configurations:
+        LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
+        LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
+        # WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
+        # WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
+        MacNode8: { vmImage: 'macOS-10.13', nodeVersion: 8.x }
+        MacNode10: { vmImage: 'macOS-10.13', nodeVersion: 10.x }
 
-# ******************************************************************************
-# Old Node test suite
-# ******************************************************************************
-- job: OldNode
-  pool:
-    vmImage: ubuntu-16.04
-  steps:
-    - task: NodeTool@0
-      inputs:
-        versionSpec: 6.x
-      displayName: 'Install Node.js 6.x'
-    - bash: tasks/e2e-old-node.sh
-      displayName: 'Run tests'
+  # ******************************************************************************
+  # Old Node test suite
+  # ******************************************************************************
+  - job: OldNode
+    pool:
+      vmImage: ubuntu-16.04
+    steps:
+      - task: NodeTool@0
+        inputs:
+          versionSpec: 6.x
+        displayName: 'Install Node.js 6.x'
+      - bash: tasks/e2e-old-node.sh
+        displayName: 'Run tests'
diff --git a/packages/create-react-app/createReactApp.js b/packages/create-react-app/createReactApp.js
@@ -225,9 +225,7 @@ function createApp(
   if (!semver.satisfies(process.version, '>=8.10.0')) {
     console.log(
       chalk.yellow(
-        `You are using Node ${
-          process.version
-        } so the project will be bootstrapped with an old unsupported version of tools.\n\n` +
+        `You are using Node ${process.version} so the project will be bootstrapped with an old unsupported version of tools.\n\n` +
           `Please update to Node 8.10 or higher for a better, fully supported experience.\n`
       )
     );
@@ -241,9 +239,7 @@ function createApp(
       if (npmInfo.npmVersion) {
         console.log(
           chalk.yellow(
-            `You are using npm ${
-              npmInfo.npmVersion
-            } so the project will be bootstrapped with an old unsupported version of tools.\n\n` +
+            `You are using npm ${npmInfo.npmVersion} so the project will be bootstrapped with an old unsupported version of tools.\n\n` +
               `Please update to npm 5 or higher for a better, fully supported experience.\n`
           )
         );
@@ -257,9 +253,7 @@ function createApp(
       if (yarnInfo.yarnVersion) {
         console.log(
           chalk.yellow(
-            `You are using Yarn ${
-              yarnInfo.yarnVersion
-            } together with the --use-pnp flag, but Plug'n'Play is only supported starting from the 1.12 release.\n\n` +
+            `You are using Yarn ${yarnInfo.yarnVersion} together with the --use-pnp flag, but Plug'n'Play is only supported starting from the 1.12 release.\n\n` +
               `Please update to Yarn 1.12 or higher for a better, fully supported experience.\n`
           )
         );

diff --git a/packages/react-dev-utils/InlineChunkHtmlPlugin.js b/packages/react-dev-utils/InlineChunkHtmlPlugin.js
@@ -17,7 +17,9 @@ class InlineChunkHtmlPlugin {
     if (tag.tagName !== 'script' || !(tag.attributes && tag.attributes.src)) {
       return tag;
     }
-    const scriptName = publicPath ? tag.attributes.src.replace(publicPath, '') : tag.attributes.src;
+    const scriptName = publicPath
+      ? tag.attributes.src.replace(publicPath, '')
+      : tag.attributes.src;
     if (!this.tests.some(test => scriptName.match(test))) {
       return tag;
     }

diff --git a/packages/react-scripts/scripts/build.js b/packages/react-scripts/scripts/build.js
@@ -124,9 +124,11 @@ checkBrowsers(paths.appPath, isInteractive)
     err => {
       const tscCompileOnError = process.env.TSC_COMPILE_ON_ERROR === 'true';
       if (tscCompileOnError) {
-        console.log(chalk.yellow(
-          'Compiled with the following type errors (you may want to check these before deploying your app):\n'
-        ));
+        console.log(
+          chalk.yellow(
+            'Compiled with the following type errors (you may want to check these before deploying your app):\n'
+          )
+        );
         printBuildError(err);
       } else {
         console.log(chalk.red('Failed to compile.\n'));