Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ‘vs’ command by: #92

Merged
merged 4 commits into from
May 7, 2015
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions commands/FBFlickerCommands.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import os
import time
import sys

import lldb
import fblldbbase as fb
Expand Down Expand Up @@ -62,20 +63,17 @@ def run(self, arguments, options):

class FlickerWalker:
def __init__(self, startView):
self.setCurrentView(startView)

self.handler = inputHelpers.FBInputHandler(lldb.debugger, self.inputCallback)
self.handler.start()
self.setCurrentView(startView, None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that oldView defaults to None, the None here can be removed.


def run(self):
while self.handler.isValid():
self.flicker()

def flicker(self):
viewHelpers.setViewHidden(self.currentView, True)
time.sleep(0.1)
viewHelpers.setViewHidden(self.currentView, False)
time.sleep(0.3)
self.keepRunning = True
initialAsync = lldb.debugger.GetAsync()
lldb.debugger.SetAsync(True) #needed so XCode doesn't hang if tap on Continue while lldb is waiting for user input in 'vs' mode
while self.keepRunning:
charRead = sys.stdin.readline().rstrip("\n")
self.inputCallback(charRead)
else:
lldb.debugger.SetAsync(initialAsync) #restore to init value

def inputCallback(self, input):
oldView = self.currentView
Expand All @@ -85,28 +83,29 @@ def inputCallback(self, input):
os.system(cmd)

print '\nI hope ' + oldView + ' was what you were looking for. I put it on your clipboard.'
viewHelpers.unmaskView(oldView)
self.keepRunning = False

self.handler.stop()
elif input == 'w':
v = superviewOfView(self.currentView)
if not v:
print 'There is no superview. Where are you trying to go?!'
self.setCurrentView(v)
self.setCurrentView(v, oldView)
elif input == 's':
v = firstSubviewOfView(self.currentView)
if not v:
print '\nThe view has no subviews.\n'
self.setCurrentView(v)
self.setCurrentView(v, oldView)
elif input == 'd':
v = nthSiblingOfView(self.currentView, -1)
if v == oldView:
print '\nThere are no sibling views to this view.\n'
self.setCurrentView(v)
self.setCurrentView(v, oldView)
elif input == 'a':
v = nthSiblingOfView(self.currentView, 1)
if v == oldView:
print '\nThere are no sibling views to this view.\n'
self.setCurrentView(v)
self.setCurrentView(v, oldView)
elif input == 'p':
recusionName = 'recursiveDescription'
isMac = runtimeHelpers.isMacintoshArch()
Expand All @@ -116,13 +115,14 @@ def inputCallback(self, input):

lldb.debugger.HandleCommand('po [(id)' + oldView + ' ' + recusionName + ']')
else:
print '\nI really have no idea what you meant by \'' + input + '\'... =\\\n'

viewHelpers.setViewHidden(oldView, False)
print '\nChisel - VS Mode: I really have no idea what you meant by \'' + input + '\'... =\\\n'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this. We don't really do this anywhere else with any output. Do you think it's necessary to mention Chisel and VS by name?


def setCurrentView(self, view):
def setCurrentView(self, view, oldView=None):
if view:
self.currentView = view
if oldView:
viewHelpers.unmaskView(oldView)
viewHelpers.maskView(self.currentView, 'red', '0.4')
lldb.debugger.HandleCommand('po (id)' + view)

def superviewOfView(view):
Expand Down