buck2_execute: implement OSS upload_blob for local_only cache uploads
#765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
thoughtpolice
force-pushed
the
aseipp/push-qvopyxnpzwkz
branch
5 times, most recently
from
0088a2f
to
1aa195d
Compare
…oads Forward-port of patch 4 in <facebook#477>, providing a clear piece of missing functionality: in the event that stdout or stderr were more than 50KiB of output when caching `local_only` actions, then this dead path was taken, and so stdout/stderr would not be uploaded successfully in the cache. Co-authored-by: Austin Seipp <aseipp@pobox.com>
thoughtpolice
force-pushed
the
aseipp/push-qvopyxnpzwkz
branch
from
1aa195d
to
3b43d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of patch 4 in #477, providing a clear piece of missing functionality: in the event that stdout or stderr were more than 50KiB of output when caching
local_onlyactions, then this dead path was taken, and so stdout/stderr would not be uploaded successfully in the cache.