feat(remote_execution): attach RequestMetadata for non-fbcode builds #310
Conversation
Summary: When doing requests to a RBE service, it's useful to attach the 'RequestMetadata' type defined by Bazel onto gRPC requests, using a specific header. This is actually already done, more or less, but only for the internal fbcode build service which uses a different and simpler Metadata structure, and a different header. Therefore attaching a new header isn't so complicated. This also ensures that non-fbcode builds of Buck2 don't bother attaching fbcode Metadata, since it's not useful and can only be tested internally there, anyway. And likewise, we don't attach OSS Bazel RequestMetadata to fbcode_build configurations, either. Test Plan: NIH. Signed-off-by: Austin Seipp <aseipp@pobox.com> Change-Id: Irrsqpmptqmzzoukzuzrqmkxsoqtxvuvx
facebook-github-bot
added
the
CLA Signed
|
This will eventually fix #256, but it isn't ready yet. Just wanted to file it to get it out of the way. We need to pump around a bit more information to get this working, I think. However, if the basic skeleton looks good, then I'll be rebasing in some more changes prior this that will plumb around more information. |
|
Could we preferably expose this via a config option rather than a build flag? We do use our internal RE in order to test the OSS build, and that doesn't build with fbcode_build, so this would break that testing. |
|
Exactly why I drafted this instead of just submitting! I figured there would be some catch I didn't understand. I can rework this a little later. |
|
#502 has landed which incorporates all of this and then some, so I'm gonna close this. Feel free to reopen if you disagree |
Summary: When doing requests to a RBE service, it's useful to attach the 'RequestMetadata' type defined by Bazel onto gRPC requests, using a specific header.
This is actually already done, more or less, but only for the internal fbcode build service which uses a different and simpler Metadata structure, and a different header. Therefore attaching a new header isn't so complicated.
This also ensures that non-fbcode builds of Buck2 don't bother attaching fbcode Metadata, since it's not useful and can only be tested internally there, anyway. And likewise, we don't attach OSS Bazel RequestMetadata to fbcode_build configurations, either.
Test Plan: NIH.
Change-Id: Irrsqpmptqmzzoukzuzrqmkxsoqtxvuvx