Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: We were conditionally adding `noprelude`, which was resulting in a difference in behavior as compared to cargo builds. 1. In cargo, all std library crates are attached using `noprelude` https://github.com/rust-lang/cargo/blob/12541d6e5ef095b03035bb316461890b40db10f4/src/cargo/core/compiler/unit_dependencies.rs#L185. 2. When actually compiling the crate, `rustc` will inject the correct prelude (depending on `no_std`, `no_core`, etc) https://github.com/rust-lang/rust/blob/243d2ca4db6f96d2d18aaf3a2381251d38eb6b0b/src/tools/rust-analyzer/crates/hir-def/src/nameres/collector.rs#L488 Given (2), it is more correct for us to follow the same pattern as `cargo` and unconditionally apply `"noprelude"`. Reviewed By: dtolnay Differential Revision: D67805532 fbshipit-source-id: 05bfc8d85e1f3d749e92420f8bd8fe160d2210a2
- Loading branch information