Skip to content

Commit

Permalink
remove redundant err conversion
Browse files Browse the repository at this point in the history
Summary:
downcosting was removed some time ago. No need to extra into
conversions anymore

Reviewed By: samkevich, JakobDegen

Differential Revision: D67972964

fbshipit-source-id: f38658283f416f548fe5c580019a1d0340b92e00
  • Loading branch information
perehonchuk authored and facebook-github-bot committed Jan 9, 2025
1 parent 490f309 commit b556b3c
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions app/buck2_bxl/src/command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,7 @@ async fn bxl(

let bxl_result = match eval_bxl(&mut ctx, bxl_key.clone()).await {
Ok(result) => result.0,
Err(e) => {
// `buck2_error::Error` has more reliable downcasting
let e: buck2_error::Error = e.into();

return Err(e.into());
}
Err(e) => return Err(e),
};

let build_results: Option<&Vec<BxlBuildResult>> = bxl_result.get_build_result_opt();
Expand Down

0 comments on commit b556b3c

Please sign in to comment.