Skip to content

Commit

Permalink
Add doc that duration = total_duration for critical path
Browse files Browse the repository at this point in the history
Reviewed By: IanChilds

Differential Revision: D67858459

fbshipit-source-id: f014d1d20f6fc4fc8e4ee31bf2c7b2e8a69a8a83
  • Loading branch information
ezgicicek authored and facebook-github-bot committed Jan 6, 2025
1 parent 6c84920 commit 505a831
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions app/buck2_data/data.proto
Original file line number Diff line number Diff line change
Expand Up @@ -540,9 +540,9 @@ message CriticalPathEntry2 {

repeated uint64 span_ids = 1;

// The duration we used to compute the critical path. This will be one of the
// durations below, but to ensure not every callsite has to know which one we
// chose, we expose it here.
// The duration we used to compute the critical path. This tracks total
// duration, but to ensure not every callsite has to know which one we chose,
// we expose it here.
google.protobuf.Duration duration = 2;

// The subset of the duration for this entry whose runtime is controlled by
Expand Down

0 comments on commit 505a831

Please sign in to comment.