Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow DEFAULT_PROJECT_VERSION to be set #224

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

qdeslandes
Copy link
Contributor

By default, if the current project version can't be deduced from the Git history, the project will use 0.0.0. This can cause issues when building the RPM package as it uses a tarball instead of the repository, meaning there is no Git history.

DEFAULT_PROJECT_VERSION can be set from the command line to define the version of the project.

By default, if the current project version can't be deduced from the Git
history, the project will use 0.0.0. This can cause issues when building
the RPM package as it uses a tarball instead of the repository, meaning
there is no Git history.

DEFAULT_PROJECT_VERSION can be set from the command line to define the
version of the project.
@qdeslandes qdeslandes merged commit b89b8c3 into facebook:main Feb 27, 2025
27 checks passed
@qdeslandes qdeslandes deleted the allow_default_version branch February 27, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants