Skip to content

Commit

Permalink
Remove extraneous semicolon from cachelib/common/MurmurHash.h
Browse files Browse the repository at this point in the history
Summary:
Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: meyering

Differential Revision: D51631139

fbshipit-source-id: 0854ead335557d01111f90ebac5b83ba964f351e
  • Loading branch information
r-barnes authored and facebook-github-bot committed Nov 29, 2023
1 parent 5c04470 commit e103198
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cachelib/common/MurmurHash.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ inline uint32_t murmurHash2(const void* key, int len, uint32_t seed) {
case 1:
h ^= data[0];
h *= m;
};
}

// Do a few final mixes of the hash to ensure the last few
// bytes are well-incorporated.
Expand Down

0 comments on commit e103198

Please sign in to comment.