Skip to content

Commit

Permalink
Change cachebench's default ODS stats upload to false
Browse files Browse the repository at this point in the history
Summary:
To my surprise, cachebench now accounts for 20% of cachelib's ODS usage.

Cachebench is run in a lot of places. CDN's cache simulator, cachelib's cogwheel stress tests, etc. Typically we know when we need the ODS stats. Most of the time, automated runs do not need ODS stats.

This changes the behavior that by default cachebench will no longer upload to ODS.

 {F1160472269}

Reviewed By: haowu14, jaesoo-fb

Differential Revision: D51630534

fbshipit-source-id: 6a8a46b815d3b6a6c8a674f7af50e6a44bf5fa4a
  • Loading branch information
Jimmy Lu authored and facebook-github-bot committed Nov 28, 2023
1 parent 6bba49b commit 22481f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cachelib/cachebench/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
#endif

#ifdef CACHEBENCH_FB_ENV
DEFINE_bool(export_to_ods, true, "Upload cachelib stats to ODS");
DEFINE_bool(export_to_ods, false, "Upload cachelib stats to ODS");
DEFINE_int32(fb303_port,
0,
"Port for cachebench fb303 service. If 0, do not export to fb303. "
Expand Down

0 comments on commit 22481f9

Please sign in to comment.