Prevent model predictions issues from erroring out Adapter.gen #3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70425553 |
saitcakmak
force-pushed
the
export-D70425553
branch
from
e21e0e5 to
9324602
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70425553 |
saitcakmak
force-pushed
the
export-D70425553
branch
from
9324602 to
ea54d2e
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Mar 1, 2025
…ook#3442) Summary: Model prediction is just a side-effect of `Adapter.gen` call and is not crucial to producing a candidate. We should not error out `gen` due to a model prediction error. Reviewed By: lena-kashtelyan Differential Revision: D70425553
|
This pull request was exported from Phabricator. Differential Revision: D70425553 |
…ook#3442) Summary: Model prediction is just a side-effect of `Adapter.gen` call and is not crucial to producing a candidate. We should not error out `gen` due to a model prediction error. Reviewed By: lena-kashtelyan Differential Revision: D70425553
saitcakmak
force-pushed
the
export-D70425553
branch
from
ea54d2e to
367b9f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70425553 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3442 +/- ##
=======================================
Coverage 95.99% 95.99%
=======================================
Files 539 539
Lines 52883 52889 +6
=======================================
+ Hits 50766 50772 +6
Misses 2117 2117 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in b3c32a0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Model prediction is just a side-effect of
Adapter.gencall and is not crucial to producing a candidate. We should not error outgendue to a model prediction error.Reviewed By: lena-kashtelyan
Differential Revision: D70425553