Allow for adhoc computation of multiple CVs at one time #3427
+117
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70200056 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3427 +/- ##
=======================================
Coverage 95.99% 96.00%
=======================================
Files 539 539
Lines 52883 52902 +19
=======================================
+ Hits 50766 50786 +20
+ Misses 2117 2116 -1 ☔ View full report in Codecov by Sentry. |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter. It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this Differential Revision: D70200056
mgarrard
force-pushed
the
export-D70200056
branch
from
a7b054b to
850ae77
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70200056 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter. It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this Differential Revision: D70200056
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter. It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this Differential Revision: D70200056
mgarrard
force-pushed
the
export-D70200056
branch
from
850ae77 to
5c51f23
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter. It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this Differential Revision: D70200056
|
This pull request was exported from Phabricator. Differential Revision: D70200056 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#3427 This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter. It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this Differential Revision: D70200056
mgarrard
force-pushed
the
export-D70200056
branch
from
5c51f23 to
2bc108c
Compare
Summary: In the previous diff we exposed an adhoc comput method for CV, but the delta between the previous plot and our new plot is a degragation in UX. This diff fixes that by: - tightening the autozoom - making the points more transparent so they are more visible individually - improving the hover - adding x and y axis titles Thanks for pointing some of these out Sam! Differential Revision: D70195847
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Feb 28, 2025
Summary: This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter. It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this Also fixed the CI bars per bernie's catch Differential Revision: D70200056
mgarrard
force-pushed
the
export-D70200056
branch
from
2bc108c to
9ea8ee6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70200056 |
mgarrard
force-pushed
the
export-D70200056
branch
from
9ea8ee6 to
b243feb
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Mar 1, 2025
Summary: This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter. It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this Also fixed the CI bars per bernie's catch Differential Revision: D70200056
Summary: Pull Request resolved: facebook#3427 This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter. It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this Also fixed the CI bars per bernie's catch Differential Revision: D70200056
|
This pull request was exported from Phabricator. Differential Revision: D70200056 |
mgarrard
force-pushed
the
export-D70200056
branch
from
b243feb to
36a00a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the second ux improvement diff for adhoc cross validation computation. This allows for mulitple metrics to be computed at one time for a single adapter.
It does not currently tile or drop down the metic names. This is a nice improvement we'd like to make, but it wasn't immediately clear how to go about this
Differential Revision: D70200056