Improve robustness in InteractionAnalysis #3407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69993111 |
mpolson64
force-pushed
the
export-D69993111
branch
from
53a1945 to
2293eeb
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Feb 21, 2025
Summary: A number of features to improve reliablity of the InteractionAnalysis. * Hide OAK kernel behind a flag which defaults to False. When false, use the current GenerationNode's adapter * If ax_parameter_sens fails log an exception and fallback to the surrogate's feature_importances * Do not plot samples on the slice and countour plots if there are more than 50 samples (it gets too cluttered) * Changed the orange and blue colors on the importance bar chart to be in the plotly color scheme * Make plot not error out on unordered choice params * Improved subtitle Differential Revision: D69993111
|
This pull request was exported from Phabricator. Differential Revision: D69993111 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Feb 24, 2025
Summary: A number of features to improve reliablity of the InteractionAnalysis. * Hide OAK kernel behind a flag which defaults to False. When false, use the current GenerationNode's adapter * If ax_parameter_sens fails log an exception and fallback to the surrogate's feature_importances * Do not plot samples on the slice and countour plots if there are more than 50 samples (it gets too cluttered) * Changed the orange and blue colors on the importance bar chart to be in the plotly color scheme * Make plot not error out on unordered choice params * Improved subtitle Differential Revision: D69993111
mpolson64
force-pushed
the
export-D69993111
branch
from
2293eeb to
abd8299
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69993111 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
==========================================
- Coverage 95.98% 95.97% -0.02%
==========================================
Files 539 539
Lines 52791 52836 +45
==========================================
+ Hits 50674 50711 +37
- Misses 2117 2125 +8 ☔ View full report in Codecov by Sentry. |
Summary: As titled. These are moderately useful here, but I really want to add them to the contour plot and I want the slice plot to match since theyre often displayed together. Differential Revision: D69988707
Summary: As titled. Differential Revision: D69989849
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Feb 24, 2025
Summary: A number of features to improve reliablity of the InteractionAnalysis. * Hide OAK kernel behind a flag which defaults to False. When false, use the current GenerationNode's adapter * If ax_parameter_sens fails log an exception and fallback to the surrogate's feature_importances * Do not plot samples on the slice and countour plots if there are more than 50 samples (it gets too cluttered) * Changed the orange and blue colors on the importance bar chart to be in the plotly color scheme * Make plot not error out on unordered choice params * Improved subtitle Differential Revision: D69993111
mpolson64
force-pushed
the
export-D69993111
branch
from
abd8299 to
d3939ec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69993111 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Feb 24, 2025
Summary: A number of features to improve reliablity of the InteractionAnalysis. * Hide OAK kernel behind a flag which defaults to False. When false, use the current GenerationNode's adapter * If ax_parameter_sens fails log an exception and fallback to the surrogate's feature_importances * Do not plot samples on the slice and countour plots if there are more than 50 samples (it gets too cluttered) * Changed the orange and blue colors on the importance bar chart to be in the plotly color scheme * Make plot not error out on unordered choice params * Improved subtitle Differential Revision: D69993111
mpolson64
force-pushed
the
export-D69993111
branch
from
d3939ec to
e9f08bd
Compare
Summary: Pull Request resolved: facebook#3407 A number of features to improve reliablity of the InteractionAnalysis. * Hide OAK kernel behind a flag which defaults to False. When false, use the current GenerationNode's adapter * If ax_parameter_sens fails log an exception and fallback to the surrogate's feature_importances * Do not plot samples on the slice and countour plots if there are more than 50 samples (it gets too cluttered) * Changed the orange and blue colors on the importance bar chart to be in the plotly color scheme * Make plot not error out on unordered choice params * Improved subtitle Differential Revision: D69993111
|
This pull request was exported from Phabricator. Differential Revision: D69993111 |
mpolson64
force-pushed
the
export-D69993111
branch
from
e9f08bd to
94f29ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A number of features to improve reliablity of the InteractionAnalysis.
Differential Revision: D69993111