[Ax] DataLoaderConfig - Only load last observation of map data by default
#3403
+173
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69992533 |
facebook-github-bot
added
CLA Signed
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 24, 2025
Summary: This commit ensures that the `Adapter` only loads a single observation by default, even for map metrics. This makes sure that any method (not-necessarily map-data aware) can be applied by default. Reviewed By: saitcakmak Differential Revision: D69992533
SebastianAment
force-pushed
the
export-D69992533
branch
from
a78451e to
86d3f87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69992533 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3403 +/- ##
=======================================
Coverage 95.99% 96.00%
=======================================
Files 539 539
Lines 52874 52903 +29
=======================================
+ Hits 50757 50787 +30
+ Misses 2117 2116 -1 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D69992533 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#3403 This commit ensures that the `Adapter` only loads a single observation by default, even for map metrics. This makes sure that any method (not-necessarily map-data aware) can be applied by default. Reviewed By: saitcakmak Differential Revision: D69992533
SebastianAment
force-pushed
the
export-D69992533
branch
2 times, most recently
from
96ef4e4 to
dc70d8d
Compare
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 28, 2025
facebook#3403) Summary: The original purpose of this commit was to ensure that the `Adapter` only loads a single observation by default, even for running and completed map metrics. This makes sure that any method (not-necessarily map-data aware) can be applied by default. To this end, we need control of the `latest_rows_per_group` of `observations_from_data`. In order to avoid increasing the number of arguments to the adapter, we package the new argument and other parameters controlling what data the model is fit to in a new `DataLoaderConfig` dataclass. Reviewed By: saitcakmak Differential Revision: D69992533
|
This pull request was exported from Phabricator. Differential Revision: D69992533 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 28, 2025
facebook#3403) Summary: The original purpose of this commit was to ensure that the `Adapter` only loads a single observation by default, even for running and completed map metrics. This makes sure that any method (not-necessarily map-data aware) can be applied by default. To this end, we need control of the `latest_rows_per_group` of `observations_from_data`. In order to avoid increasing the number of arguments to the adapter, we package the new argument and other parameters controlling what data the model is fit to in a new `DataLoaderConfig` dataclass. Reviewed By: saitcakmak Differential Revision: D69992533
SebastianAment
force-pushed
the
export-D69992533
branch
from
dc70d8d to
92bf8e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69992533 |
SebastianAment
changed the title
DataLoaderConfig - Only load last observation of map data by default
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 28, 2025
facebook#3403) Summary: The original purpose of this commit was to ensure that the `Adapter` only loads a single observation by default, even for running and completed map metrics. This makes sure that any method (not-necessarily map-data aware) can be applied by default. To this end, we need control of the `latest_rows_per_group` of `observations_from_data`. In order to avoid increasing the number of arguments to the adapter, we package the new argument and other parameters controlling what data the model is fit to in a new `DataLoaderConfig` dataclass. Reviewed By: saitcakmak Differential Revision: D69992533
SebastianAment
force-pushed
the
export-D69992533
branch
from
92bf8e0 to
1db600c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69992533 |
facebook#3403) Summary: The original purpose of this commit was to ensure that the `Adapter` only loads a single observation by default, even for running and completed map metrics. This makes sure that any method (not-necessarily map-data aware) can be applied by default. To this end, we need control of the `latest_rows_per_group` of `observations_from_data`. In order to avoid increasing the number of arguments to the adapter, we package the new argument and other parameters controlling what data the model is fit to in a new `DataLoaderConfig` dataclass. Reviewed By: saitcakmak Differential Revision: D69992533
SebastianAment
force-pushed
the
export-D69992533
branch
from
1db600c to
fad0301
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69992533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit ensures that the
Adapteronly loads a single observation by default, even for map metrics. This makes sure that any method (not-necessarily map-data aware) can be applied by default.Differential Revision: D69992533