When constructing parameters from lists of names and values, ensure that names and values have the same length #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat names and values have the same length
Summary:
Context: There is code like
`parameters={p: float(xbest[i]) for i, p in enumerate(self.parameters)}`
If `xbest` is longer than `self.parameters` (which indicates a problem), the extra elements in `xbest` will be silently discarded. The new behavior will generate an exception.
I did not check everywhere that this might be a problem, just in the places where it was causing trouble for me.
This PR:
* Updates two places where parameters are constructed to use `dict(zip(..., strict=True))`
Reviewed By: Balandat
Differential Revision: D68035646
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68035646 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3231 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 513 513
Lines 51687 51689 +2
=======================================
+ Hits 49558 49560 +2
Misses 2129 2129 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in bdceb7f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: There is code like
parameters={p: float(xbest[i]) for i, p in enumerate(self.parameters)}If
xbestis longer thanself.parameters(which indicates a problem), the extra elements inxbestwill be silently discarded. The new behavior will generate an exception.I did not check everywhere that this might be a problem, just in the places where it was causing trouble for me.
This PR:
dict(zip(..., strict=True))Reviewed By: Balandat
Differential Revision: D68035646