Bring back ax/benchmark/__init__.py #2719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2719 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 490 490
Lines 47738 47738
=======================================
Hits 45541 45541
Misses 2197 2197 ☔ View full report in Codecov by Sentry. |
Summary: Removing `__init__.py` makes the module not discoverable when installed with `pip`, leading to `ModuleNotFoundError: No module named 'ax.benchmark'`. See https://github.com/pytorch/botorch/actions/runs/10581831529/job/29320089546 Reviewed By: mpolson64 Differential Revision: D61861709 Pulled By: saitcakmak
facebook-github-bot
force-pushed
the
saitcakmak-patch-1
branch
from
51a3d5c to
772ab5f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61861709 |
|
@saitcakmak merged this pull request in 30a866f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
__init__.pymakes the module not discoverable when installed withpip, leading toModuleNotFoundError: No module named 'ax.benchmark'. See https://github.com/pytorch/botorch/actions/runs/10581831529/job/29320089546