Compute ground-truth optimization trace on BenchmarkProblem #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61404056 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
=======================================
Coverage 95.39% 95.40%
=======================================
Files 492 492
Lines 47920 47952 +32
=======================================
+ Hits 45715 45747 +32
Misses 2205 2205 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D61404056 |
esantorella
force-pushed
the
export-D61404056
branch
from
93c84f2 to
27332b6
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 23, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Reviewed By: saitcakmak Differential Revision: D61404056
|
This pull request was exported from Phabricator. Differential Revision: D61404056 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 23, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Reviewed By: saitcakmak Differential Revision: D61404056
esantorella
force-pushed
the
export-D61404056
branch
from
27332b6 to
92b8414
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61404056 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Reviewed By: saitcakmak Differential Revision: D61404056
esantorella
force-pushed
the
export-D61404056
branch
from
92b8414 to
5d9beaf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61404056 |
esantorella
force-pushed
the
export-D61404056
branch
from
5d9beaf to
8bdecb6
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Reviewed By: saitcakmak Differential Revision: D61404056
|
This pull request was exported from Phabricator. Differential Revision: D61404056 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Reviewed By: saitcakmak Differential Revision: D61404056
esantorella
force-pushed
the
export-D61404056
branch
from
8bdecb6 to
38c6b2a
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Differential Revision: D61404056 Reviewed By: saitcakmak
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 25, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Reviewed By: saitcakmak Differential Revision: D61404056
esantorella
force-pushed
the
export-D61404056
branch
from
38c6b2a to
b4e8655
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61404056 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 25, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Differential Revision: D61404056 Reviewed By: saitcakmak
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 26, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Differential Revision: D61404056 Reviewed By: saitcakmak
|
This pull request was exported from Phabricator. Differential Revision: D61404056 |
esantorella
force-pushed
the
export-D61404056
branch
from
b4e8655 to
200349f
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 27, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Reviewed By: saitcakmak Differential Revision: D61404056
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 27, 2024
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Differential Revision: D61404056 Reviewed By: saitcakmak
…#2704) Summary: Pull Request resolved: facebook#2704 This currently doesn't change behavior, but enables more flexibility by redefining `Problem.get_ground_truth_opt_trace` or `BenchmarkRunner.get_Y_true`. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results. Reviewed By: saitcakmak Differential Revision: D61404056
|
This pull request was exported from Phabricator. Differential Revision: D61404056 |
esantorella
force-pushed
the
export-D61404056
branch
from
200349f to
3d39c1e
Compare
|
This pull request has been merged in 05fd370. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This currently doesn't change behavior, but enables more flexibility by redefining
Problem.get_ground_truth_opt_traceorBenchmarkRunner.get_Y_true. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results.Reviewed By: saitcakmak
Differential Revision: D61404056