Remove unused experiment arg from compute_model_fit_metrics_from_modelbridge #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D58208209 |
facebook-github-bot
added
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
==========================================
- Coverage 95.28% 95.28% -0.01%
==========================================
Files 485 485
Lines 47406 47405 -1
==========================================
- Hits 45171 45168 -3
- Misses 2235 2237 +2 ☔ View full report in Codecov by Sentry. |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Jun 6, 2024
…lbridge (facebook#2504) Summary: This will make it easier to call on model spec. Reviewed By: saitcakmak Differential Revision: D58208209
danielcohenlive
force-pushed
the
export-D58208209
branch
from
18ededb to
6fbaf7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58208209 |
…lbridge (facebook#2504) Summary: This will make it easier to call on model spec. Reviewed By: saitcakmak Differential Revision: D58208209
danielcohenlive
force-pushed
the
export-D58208209
branch
from
6fbaf7c to
01c07f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58208209 |
|
This pull request has been merged in 2e8900f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This will make it easier to call on model spec.
Reviewed By: saitcakmak
Differential Revision: D58208209