node <> model 3/n: update should_transition_to_next_node #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57132018 |
|
This pull request was exported from Phabricator. Differential Revision: D57132018 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
Summary: Pull Request resolved: facebook#2447 This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2447 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 496 496
Lines 48274 48300 +26
=======================================
+ Hits 46012 46039 +27
+ Misses 2262 2261 -1 ☔ View full report in Codecov by Sentry. |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
|
This pull request was exported from Phabricator. Differential Revision: D57132018 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 9, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 10, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 10, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Differential Revision: D57132018
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 11, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Reviewed By: lena-kashtelyan Differential Revision: D57132018
mgarrard
force-pushed
the
export-D57132018
branch
from
29c3146 to
bbb9873
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57132018 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 11, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Reviewed By: lena-kashtelyan Differential Revision: D57132018
mgarrard
force-pushed
the
export-D57132018
branch
from
bbb9873 to
6dbffd2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57132018 |
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 11, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Reviewed By: lena-kashtelyan Differential Revision: D57132018
mgarrard
force-pushed
the
export-D57132018
branch
from
6dbffd2 to
ec00415
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
May 13, 2024
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Reviewed By: lena-kashtelyan Differential Revision: D57132018
|
This pull request was exported from Phabricator. Differential Revision: D57132018 |
Summary: This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward. If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important. Reviewed By: lena-kashtelyan Differential Revision: D57132018
mgarrard
force-pushed
the
export-D57132018
branch
from
ec00415 to
ec7805a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57132018 |
|
This pull request has been merged in 8926797. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff builds on the previous diff, and uses the new property that we added for TC to decide if the gs should move forward.
If all criterion that specificy a transition edge between nodes are met, we move to that node. We progress through tc in order -- meaning when constructing a gs tc ordering is important.
Differential Revision: D57132018