Update PairwiseModelBridge to support non-preference outcomes #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56869674 |
|
@myazdani has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…ok#2424) Summary: `PairwiseModelBridge` breaks if data passed to it include outcomes that are not preferences. We update it so that both supervised and ranking outcomes are supported. The updated bridge will ignore any outcome that is not a preference outcome (ie, `Keys.PAIRWISE_PREFERENCE_QUERY`). Pull Request resolved: facebook#2424 Differential Revision: D56869674 Pulled By: myazdani
|
This pull request was exported from Phabricator. Differential Revision: D56869674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PairwiseModelBridgebreaks if data passed to it include outcomes that are not preferences. We update it so that both supervised and ranking outcomes are supported.The updated bridge will ignore any outcome that is not a preference outcome (ie,
Keys.PAIRWISE_PREFERENCE_QUERY).Differential Revision: D56869674