do not group by time cols when creating observations #2293
Closed
+154
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55099571 |
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Mar 20, 2024
Summary: See title. Add the time columns only if all metrics for a given trial-arm pair have the same start/end time. This means that if one wants time to be included, then they should ensure the metric gives the same start/end time for each all metrics for a single trial-arm pair. This was causing an issue where status quo data for a single trial could be split across multiple observations because the metrics had different start and end times. This largely reverts D54017025. Reviewed By: Balandat Differential Revision: D55099571
sdaulton
force-pushed
the
export-D55099571
branch
from
4ca7906 to
c69d58f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55099571 |
Summary: See title. Add the time columns only if all metrics for a given trial-arm pair have the same start/end time. This means that if one wants time to be included, then they should ensure the metric gives the same start/end time for each all metrics for a single trial-arm pair. This was causing an issue where status quo data for a single trial could be split across multiple observations because the metrics had different start and end times. This largely reverts D54017025. Reviewed By: Balandat Differential Revision: D55099571
sdaulton
force-pushed
the
export-D55099571
branch
from
c69d58f to
f0a6f0d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55099571 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
==========================================
- Coverage 94.91% 94.90% -0.01%
==========================================
Files 489 489
Lines 47611 47658 +47
==========================================
+ Hits 45190 45231 +41
- Misses 2421 2427 +6 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in fbcad21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See title. Add the time columns only if all metrics for a given trial-arm pair have the same start/end time. This means that if one wants time to be included, then they should ensure the metric gives the same start/end time for each all metrics for a single trial-arm pair.
This was causing an issue where status quo data for a single trial could be split across multiple observations because the metrics had different start and end times. This largely reverts D54017025.
Reviewed By: Balandat
Differential Revision: D55099571