ExternalGenerationNode #2266
Closed
ExternalGenerationNode #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54500745 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2266 +/- ##
==========================================
+ Coverage 94.89% 94.90% +0.01%
==========================================
Files 479 481 +2
Lines 46946 47060 +114
==========================================
+ Hits 44548 44661 +113
- Misses 2398 2399 +1 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D54500745 |
saitcakmak
force-pushed
the
export-D54500745
branch
from
0b5eebf to
959fc76
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Mar 13, 2024
Summary: Implements a `ExternalGenerationNode` class, which defers to arbitrary non-Ax / BoTorch based methods for candidate generation. This class mostly retains the signature of the `GenerationNode` for compatibility with `GenerationStrategy`, and requires the user to implement only the necessary bits. Since it is compatible with `GenerationStrategy`, it can be easily combined with other `GenerationNode`, e.g., with Sobol to use a shared initialization with other generation strategies. This makes it particularly suitable for benchmarking against other methods from Ax. The user needs to implement `__init__`, `update_model_state` and `get_next_trial_parameters`. Differential Revision: D54500745
Summary: Pull Request resolved: facebook#2266 Implements a `ExternalGenerationNode` class, which defers to arbitrary non-Ax / BoTorch based methods for candidate generation. This class mostly retains the signature of the `GenerationNode` for compatibility with `GenerationStrategy`, and requires the user to implement only the necessary bits. Since it is compatible with `GenerationStrategy`, it can be easily combined with other `GenerationNode`, e.g., with Sobol to use a shared initialization with other generation strategies. This makes it particularly suitable for benchmarking against other methods from Ax. The user needs to implement `__init__`, `update_model_state` and `get_next_trial_parameters`. Reviewed By: Balandat Differential Revision: D54500745
|
This pull request was exported from Phabricator. Differential Revision: D54500745 |
saitcakmak
force-pushed
the
export-D54500745
branch
from
959fc76 to
e652d92
Compare
|
This pull request has been merged in 2081f6f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implements a
ExternalGenerationNodeclass, which defers to arbitrary non-Ax / BoTorch based methods for candidate generation. This class mostly retains the signature of theGenerationNodefor compatibility withGenerationStrategy, and requires the user to implement only the necessary bits. Since it is compatible withGenerationStrategy, it can be easily combined with otherGenerationNode, e.g., with Sobol to use a shared initialization with other generation strategies. This makes it particularly suitable for benchmarking against other methods from Ax.The user needs to implement
__init__,update_model_stateandget_next_trial_parameters.Differential Revision: D54500745