Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions Workflows #1822

Closed
wants to merge 7 commits into from
Closed

Update GitHub Actions Workflows #1822

wants to merge 7 commits into from

Conversation

saitcakmak
Copy link
Contributor

  • Update checkout and python-setup to v3 & v4, respectively.
  • Create a new reusable_test workflow and use this everywhere unit tests are ran. This supports pinned and latest BoTorch, as well as minimal and full dependencies.
  • Update the reusable_tutorials workflow to support both latest and pinned BoTorch.
  • Create a cron_pinned workflow and update cron to run only latest BoTorch version. This should make nightly cron into a much higher signal workflow and prevent it from failing due to latest Ax diverging from pinned BoTorch.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 6, 2023
@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (79c9705) 94.59% compared to head (d7c314f) 94.59%.

❗ Current head d7c314f differs from pull request most recent head a4c792f. Consider uploading reports for the commit a4c792f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1822   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files         454      454           
  Lines       42873    42873           
=======================================
  Hits        40554    40554           
  Misses       2319     2319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.9", "3.10"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start testing against 3.11 (here and in other places)? Botorch does...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should but this is currently blocked on pytorch/torchx#744

@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@saitcakmak merged this pull request in 5dc443f.

@Balandat Balandat deleted the workflows branch September 7, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants