Add missing __init__ file #1672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1672 +/- ##
=======================================
Coverage 94.80% 94.80%
=======================================
Files 448 448
Lines 41233 41233
=======================================
Hits 39093 39093
Misses 2140 2140
☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
that referenced
this pull request
Jun 21, 2023
Summary: ~Although I can't reproduce the error locally,~ I believe this is the cause of the `ModuleNotFoundError: No module named 'ax.models.torch.botorch_modular.input_constructors'` errors in https://github.com/pytorch/botorch/actions/runs/5329180791/jobs/9654605153 Actually, I managed to repro. This is indeed the cause / fix for those failures. Before: <img width="851" alt="Screenshot 2023-06-20 at 7 26 59 PM" src="https://github.com/facebook/Ax/assets/9263852/134ffec8-8335-4dc3-8e4d-77c4c50adc9f"> After: <img width="849" alt="Screenshot 2023-06-20 at 7 29 56 PM" src="https://github.com/facebook/Ax/assets/9263852/e762caf8-4abc-4c80-bab4-2d7cad8d83ff"> Pull Request resolved: #1672 Reviewed By: Balandat Differential Revision: D46884977 Pulled By: saitcakmak fbshipit-source-id: 3873d406a4635123a44d671070f72a4013160933
saitcakmak
force-pushed
the
saitcakmak-patch-2
branch
from
82edca0 to
2ae3929
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46884977 |
Summary: Fixes failures in lint & docs workflows. Pull Request resolved: #1671 Differential Revision: https://internalfb.com/D46883168 Pulled By: saitcakmak fbshipit-source-id: 06178615bdf69de685701ad23827a0b9b6310cc6
Summary: ~Although I can't reproduce the error locally,~ I believe this is the cause of the `ModuleNotFoundError: No module named 'ax.models.torch.botorch_modular.input_constructors'` errors in https://github.com/pytorch/botorch/actions/runs/5329180791/jobs/9654605153 Actually, I managed to repro. This is indeed the cause / fix for those failures. Before: <img width="851" alt="Screenshot 2023-06-20 at 7 26 59 PM" src="https://github.com/facebook/Ax/assets/9263852/134ffec8-8335-4dc3-8e4d-77c4c50adc9f"> After: <img width="849" alt="Screenshot 2023-06-20 at 7 29 56 PM" src="https://github.com/facebook/Ax/assets/9263852/e762caf8-4abc-4c80-bab4-2d7cad8d83ff"> Pull Request resolved: #1672 Reviewed By: Balandat Differential Revision: D46884977 Pulled By: saitcakmak fbshipit-source-id: 40426d7857d47188f7c4600a34b441bd667bf58e
saitcakmak
force-pushed
the
saitcakmak-patch-2
branch
from
2ae3929 to
0018f1f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46884977 |
esantorella
reviewed
Jun 21, 2023
| @@ -391,7 +391,10 @@ def get_standard_plots( | |||
| if global_sensitivity_analysis and isinstance(model, TorchModelBridge): | |||
| try: | |||
| sens = ax_parameter_sens(model, order="total") | |||
| importance_measure = '<a href="https://en.wikipedia.org/wiki/Variance-based_sensitivity_analysis">Variance-based sensitivity analysis</a>' | |||
| importance_measure = ( | |||
| '<a href="https://en.wikipedia.org/wiki/Variance-based_' | |||
There was a problem hiding this comment.
Thanks for fixing this!
|
@saitcakmak merged this pull request in 637847e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I can't reproduce the error locally,I believe this is the cause of theModuleNotFoundError: No module named 'ax.models.torch.botorch_modular.input_constructors'errors in https://github.com/pytorch/botorch/actions/runs/5329180791/jobs/9654605153Actually, I managed to repro. This is indeed the cause / fix for those failures.
Before:
After: