Skip to content

Commit

Permalink
NoisyExpectedHypervolumeMixin (#1909)
Browse files Browse the repository at this point in the history
Summary:
X-link: pytorch/botorch#2045

Pull Request resolved: #1909

This commit introduces `NoisyExpectedHypervolumeMixin`, a derivative of `CachedCholeskyMCSamplerMixin` that separates out much of the Pareto-partitioning required for `qNEHVI`.

Reviewed By: Balandat

Differential Revision: D50337502

fbshipit-source-id: 1e24a4bc884ffa5b3fddb72730007e39fa3dae7e
  • Loading branch information
SebastianAment authored and facebook-github-bot committed Oct 23, 2023
1 parent f7d01cf commit 421dd10
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ax/models/tests/test_botorch_moo_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from unittest import mock

import ax.models.torch.botorch_moo_defaults as botorch_moo_defaults
import botorch.utils.multi_objective.hypervolume as hypervolume
import numpy as np
import torch
from ax.core.search_space import SearchSpaceDigest
Expand Down Expand Up @@ -49,7 +50,7 @@
"botorch.acquisition.factory.moo_monte_carlo.qExpectedHypervolumeImprovement"
)
NEHVI_PARTITIONING_PATH = (
"botorch.acquisition.multi_objective.monte_carlo.FastNondominatedPartitioning"
"botorch.utils.multi_objective.hypervolume.FastNondominatedPartitioning"
)
EHVI_PARTITIONING_PATH = "botorch.acquisition.factory.FastNondominatedPartitioning"

Expand Down Expand Up @@ -423,7 +424,7 @@ def test_BotorchMOOModel_with_qehvi(
_mock_partitioning = es.enter_context(
mock.patch(
partitioning_path,
wraps=moo_monte_carlo.FastNondominatedPartitioning,
wraps=hypervolume.FastNondominatedPartitioning,
)
)
torch_opt_config = TorchOptConfig(
Expand Down

0 comments on commit 421dd10

Please sign in to comment.