Skip to content

Commit

Permalink
Raise FullyBayesianPosterior deprecation warning only when used (#2004)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2004

X-link: pytorch/botorch#2116

Currently, this warns on import, which leads to excessive warnings since it is imported in the `__init__` file. Moving to `FullyBayesianPosterior.__init__` resolves the issue.

Reviewed By: Balandat, esantorella

Differential Revision: D51445186

fbshipit-source-id: 58a2137ad7d1b79d391e606e601e600bf35b9656
  • Loading branch information
saitcakmak authored and facebook-github-bot committed Nov 18, 2023
1 parent 6dba26f commit 2916d0d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ax/models/torch/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ def pick_best_out_of_sample_point_acqf_class(
def predict_from_model(model: Model, X: Tensor) -> Tuple[Tensor, Tensor]:
r"""Predicts outcomes given a model and input tensor.
For a `FullyBayesianPosterior` we currently use a Gaussian approximation where we
For a `GaussianMixturePosterior` we currently use a Gaussian approximation where we
compute the mean and variance of the Gaussian mixture. This should ideally be
changed to compute quantiles instead when Ax supports non-Gaussian distributions.
Expand Down

0 comments on commit 2916d0d

Please sign in to comment.