Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Color): add isUnrecognised property #9936

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

jiayihu
Copy link
Contributor

@jiayihu jiayihu commented Jun 23, 2024

Allow to be able to tell if a color was not recognised/invalid, otherwise it's not possible to tell between true black and invalid color.

Copy link

codesandbox bot commented Jun 23, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@asturur
Copy link
Member

asturur commented Jun 24, 2024

yep good point.

@asturur
Copy link
Member

asturur commented Jun 24, 2024

Please add a changelog and a quick test and let's move on, i was about to pack the latest release

@jiayihu
Copy link
Contributor Author

jiayihu commented Jun 24, 2024

Done

@asturur asturur merged commit ea0ef73 into fabricjs:master Jun 25, 2024
20 of 22 checks passed
@jiayihu jiayihu deleted the fix/color-fallback branch June 25, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants