-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(): Add Jest coverage to the report #9836
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Build Stats
|
Jest coverage seems too much generous to me, probably some stuff is run over without actually testing |
Total Coverage: Coverage report------------------------------------|---------|----------|---------|---------|----------------------
|
…o add-jest-coverage
It didn't work before because jest and instanbul don't play nicely together IIRC and report bogus data. |
i can't say for sure, i would need to cover a new line to be sure. Mixing e2e and unit and visual test is anyway giving us a very generic idea of coverage. Probably a lot of lines are covered without asserts checking for them Consider the few JEST only tests we have are giving 77% coverage that seems a lot. |
Description
For some reason this didn't work before, while now it seems to work fine.
This PR adds JEST coverage to our global coverage.
In Action