Avoid unwanted mutation to passed objects array to Group constructor #9151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
previously approved these changes
Aug 13, 2023
asturur
reviewed
Aug 13, 2023
|
maybe a dumb unit test , an new group JEST file, that tests that given an array and doing a collection mutation on it, the original array is still intact, and that the 2 arrays do not pass the strict equality test. If we wanted to go full mutation protection we should clone the object, that would make the constructor async and i don't think we should do it at all. |
jiayihu
changed the title
|
Done. Renamed changelog text and added a Jest test. |
ShaMan123
reviewed
Aug 14, 2023
ShaMan123
approved these changes
Aug 14, 2023
asturur
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix: since
Collectionmutates the_objectsarray, this can cause really hard-to-debug bugs if the passed array of objects is used for other purposes as well by the application. To avoid any complication for the unaware developer, a copy should be made.