fix(TS): ITextBehaviour enterEditing type

[jiayihu]

Very very minor change. The event was type correctly: 'editing:entered': never | { e: TPointerEvent }, but the method required e to be defined.

[ShaMan123]

Makes sense
Needed when calling the method imperatively

[ShaMan123]

We cab still pass the same object to the event because the fire method passes an empty object anyways

[jiayihu]

We cab still pass the same object to the event because the fire method passes an empty object anyways

The type would be different, the passed object would be of type { e: TPointerEvent | undefined }, whereas the event has type never | { e: TPointerEvent }

[ShaMan123]

It doesn't matter

fabric.js/src/Observable.ts

Line 177 in 2a484bf

listenersForEvent[i].call(this, options || {});

[jiayihu]

{ e: undefined } is not the same as undefined. I was also referring to the type, which for editing:entered is types as 'editing:entered': never | { e: TPointerEvent } so you can't pass { e: undefined }

[ShaMan123]

I know
I wrote the type
fire passes an object anyways so it can be { e?: TPointerEvent } instead of never | { e: TPointerEvent }

[ShaMan123]

I am meticulous only because I was instructed to keep type PRs pure
I know it can be annoying

[jiayihu]

fire passes an object anyways so it can be { e?: TPointerEvent } instead of never | { e: TPointerEvent }

Aahh so you were suggesting to change the event type to be { e?: TPointerEvent }? In that case, you need to be clear in your comments, most of the time I can hardly understand what you mean you exactly 😄

I am meticulous only because I was instructed to keep type PRs pure

For instance, here by "pure" you mean keeping the PR type-only without runtime JS changes? I can't every time have to guess what's in your mind. For me "pure" has a different meaning, typically associated with "pure functions", i.e. without side effects.

[ShaMan123]

I looked again at the code
There are other instances of this and they use an optional event so this should as well

fabric.js/src/EventTypeDefs.ts

Lines 180 to 193 in d0d98db

	interface CanvasSelectionEvents {
	'selection:created': Partial<TEvent> & {
	selected: FabricObject[];
	};
	'selection:updated': Partial<TEvent> & {
	selected: FabricObject[];
	deselected: FabricObject[];
	};
	'before:selection:cleared': Partial<TEvent> & {
	deselected: FabricObject[];
	};
	'selection:cleared': Partial<TEvent> & {
	deselected: FabricObject[];
	};