Update Text.ts #9041
Update Text.ts #9041
Conversation
There was a problem hiding this comment.
Please run npm run prettier:write and commit
After that the diff will be meaningful
The fact that tests pass is meaningless because they are passing without this PR, meaning this is not covered by a test so you should add a test that is failing on master and passing here
| ? this.fontFamily | ||
| : `"${style.fontFamily}"`; |
There was a problem hiding this comment.
I thought the point was to use family
There was a problem hiding this comment.
Thank you @ShaMan123 for guiding me through.
The highlighted line (const family = style.fontFamily || this.fontFamily;) checks if the style object has a valid fontFamily property. If it does, family will be assigned the value of style.fontFamily. Otherwise, it will fall back to the this.fontFamily property.
I have run npm run prettier:write. Are there any other commands or tests that needs to be run?
Could you help against this
There was a problem hiding this comment.
I have also added a unit test in the text/unit file and all tests are passing
|
Please check the request for the git blame verification in the original issue. |
| family === undefined || | ||
| family.indexOf("'") > -1 || | ||
| family.indexOf(',') > -1 || | ||
| family.indexOf('"') > -1 || | ||
| fontIsGeneric | ||
| ? style.fontFamily | ||
| ? this.fontFamily |
| const style = styleObject || this; | ||
| const family = style.fontFamily || this.fontFamily; | ||
| const fontIsGeneric = Text.genericFonts.indexOf(family.toLowerCase()) > -1; | ||
| const formattedFontFamily = | ||
| family === undefined || |
There was a problem hiding this comment.
This will never happen now
This is a fix to Text style bug? #9010 issue.
I have tested the code and it is passing all checks.