fix(Path) Issue 8852 fix a bug in path parsing

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## [next]
 
+- fix(Path, Obect) Fix path parsing edge case for zeroed arc command and for too small canvas patterns [#8853](https://github.com/fabricjs/fabric.js/pull/8853)
+
+## [6.0.0-beta3]
+
 - chore(TS): Path type fixes [#8842](https://github.com/fabricjs/fabric.js/pull/8842)
 - fix(TS): add types to some untyped empty arrays [#8830](https://github.com/fabricjs/fabric.js/pull/8830)
 - chore(TS): Complete typings for toObject/fromObject [#8756](https://github.com/fabricjs/fabric.js/pull/8756)

src/shapes/Object/Object.ts

@@ -1238,8 +1238,10 @@ export class FabricObject<
       retinaScaling = this.getCanvasRetinaScaling(),
       width = dims.x / this.scaleX / retinaScaling,
       height = dims.y / this.scaleY / retinaScaling;
-    pCanvas.width = width;
-    pCanvas.height = height;
+    // in case width and height are less than 1px, we have to round up.
+    // since the pattern is no-repeat, this is fine
+    pCanvas.width = Math.ceil(width);
+    pCanvas.height = Math.ceil(height);
     const pCtx = pCanvas.getContext('2d');
     if (!pCtx) {
       return;

src/util/path/index.ts

@@ -94,6 +94,9 @@ const arcToSegments = (
   sweep: number,
   rotateX: TRadian
 ): TParsedAbsoluteCubicCurveCommand[] => {
+  if (rx === 0 || ry === 0) {
+    return [];
+  }
   let fromX = 0,
     fromY = 0,
     root = 0;

test/unit/path.js

@@ -396,4 +396,9 @@
       done();
     });
   });
+
+  QUnit.test('can parse arcs with rx and ry set to 0', function(assert) {
+    var path = new fabric.Path('M62.87543,168.19448H78.75166a0,0,0,0,1,0,0v1.9884a6.394,6.394,0,0,1-6.394,6.394H69.26939a6.394,6.394,0,0,1-6.394-6.394v-1.9884A0,0,0,0,1,62.87543,168.19448Z');
+    assert.equal(path.path.length, 9);
+  });
 })();

test/visual/svg_import.js

@@ -97,6 +97,8 @@
     '177',
     'polygons',
     'polygons-rounded',
+    'light-bulb',
+    'accordion',
   ].map(createTestFromSVG);
 
   tests.forEach(visualTestLoop(QUnit));