Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TS): export typedefs #8717

Closed
wants to merge 1 commit into from
Closed

Conversation

robothot
Copy link
Contributor

@robothot robothot commented Feb 21, 2023

Motivation

export types in v6

Description

solve #8715

Changes

Gist

In Action

@robothot robothot changed the title chore: export typedefs chore(TS): export typedefs Feb 21, 2023
@wuxingping
Copy link

Motivation

export types in v6

Description

solve #8715

Changes

Gist

In Action

okay,thank you,i think you should commit to merge v6(6.0.0-beta1) as well.i have been using v6.thank you so much.

@robothot
Copy link
Contributor Author

@asturur Can you review the code for me when you are free ?

@ShaMan123
Copy link
Contributor

Jumping in.
I have noticed the problem of types not exported.
I am not sure this fixes it properly.
We need to export all meaningful types.

@robothot
Copy link
Contributor Author

I see here that seems to have solved the problem #8725

@robothot robothot closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants