-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TS): types for toObject
and additionaProperties
#8677
Merged
Merged
Changes from 31 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
445e630
interface
ShaMan123 f50c4c9
Update Object.ts
ShaMan123 f732868
Update CHANGELOG.md
ShaMan123 de8f05f
interactive object props
ShaMan123 6d5903c
circle props
ShaMan123 bed8b49
ws
ShaMan123 c5eb848
Update defaultValues.ts
ShaMan123 1179483
`toObject` types
ShaMan123 098bb2a
fix generics
ShaMan123 e8c0b9f
`fromObject` generic return value
ShaMan123 9a0af44
Update Circle.ts
ShaMan123 b13e583
Update ObjectProps.ts
ShaMan123 d715e07
Update Object.ts
ShaMan123 f49420d
transient: not to break types for now
ShaMan123 6486798
Merge branch 'master' into types-to-object
ShaMan123 0471c17
Merge branch 'master' into types-to-object
asturur a405c30
Merge branch 'master' into types-to-object
ShaMan123 440d222
Update Shadow.ts
ShaMan123 514de91
props redo
ShaMan123 657dd54
Update Circle.ts
ShaMan123 7cf6e8a
switch generic order
ShaMan123 f4d3843
Update typedefs.ts
ShaMan123 d1c229f
finish
ShaMan123 5e8fa31
Update Circle.ts
ShaMan123 8dd3e5a
cleanup
ShaMan123 6fb954e
Update Circle.ts
ShaMan123 3391f70
Update Circle.ts
ShaMan123 266ddce
Update CHANGELOG.md
ShaMan123 21d5334
cleanup
ShaMan123 1ca52e8
Update Object.ts
ShaMan123 40f3241
imports
ShaMan123 1851226
cleanup
ShaMan123 87a8ac4
Merge branch 'master' into types-to-object
asturur 781ee39
restore import orders
asturur 68a45c7
Update Circle.ts
asturur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something i noticed in the previous PR too, i would argue this can be solved with a declaration?
is weird that TS would force me to add code that does nothing to obey types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct
I was lazy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another TS problem. Static class methods can't be generic using straight forward TS