-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): _initRetinaScaling
initializaing the scaling regardless of settings in Canvas.
#8565
Conversation
Build Stats
|
How the regression was created do we know? the fix you propose seems unrelated to the changes that happend in that pr. |
If you look at the override of fabric.js/src/canvas/canvas.class.ts Lines 527 to 530 in 70f955c
fabric.js/src/canvas/static_canvas.class.ts Lines 384 to 389 in 70f955c
|
the most simple fix should be
But it makes more sense to check outside of a method named initRetinaScaling |
ok now i understand. Regarding what makes more sense is usually the smaller change visually. |
_initRetinaScaling
regression_initRetinaScaling
initializaing the scaling regardless of settings in Canvas.
…tina settings in Canvas class. (fabricjs#8565)
…tina settings in Canvas class. (#8565)
Motivation
Description
fixes the regression from #8510
I decided to open this PR to have a pure scope for this fix cause I guess that is what you want, instead of fixing as part of #8520
Decide if you want to close this and merge #8520 or merge this and then that. Anyways if you do the second when dealing with conflict #8520 should win.
Changes
now
_initRetinaScaling
should be called only ifisRetinaScaling
(doesn't check in the method as previously did)Gist
In Action