-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create functions to generate standard control set for whoever wants new control set and new controls per object #8415
Conversation
Build Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
A great step forward for supplying some kind of alternative.
We need to expose these exports, the index file needs to be modified to export this file
@@ -14,7 +14,8 @@ import { | |||
} from './actions'; | |||
import { Control } from './control.class'; | |||
|
|||
export const defaultControls = { | |||
// use this function if you want to generate new controls for every instance | |||
export const createObjectDefaultControls = () => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming createDefaultControls?
As soon as we are done with TS + imports, we can make a bundle and the index.js file goes away. |
For Immutability super fans this function can help to have quickly a new control set and new controls when creating new instances
Motivation
Description
Changes
Gist
closes #7914
In Action