Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): skewing controls #8380

Merged
merged 68 commits into from
Oct 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
ed66b81
WIP
ShaMan123 Oct 12, 2022
0e5305a
Merge branch 'master' into fix-skewing-controls
ShaMan123 Oct 12, 2022
c4633cb
Merge branch 'master' into fix-skewing-controls
ShaMan123 Oct 17, 2022
e30dd32
fix skewing
ShaMan123 Oct 18, 2022
465149f
Update controls_handlers.js
ShaMan123 Oct 18, 2022
95b8b39
Update CHANGELOG.md
ShaMan123 Oct 18, 2022
06cdb64
fix(): use set
ShaMan123 Oct 18, 2022
793df67
Update object.class.ts
ShaMan123 Oct 18, 2022
c6f000d
Update controls.actions.ts
ShaMan123 Oct 18, 2022
d4996d1
ws
ShaMan123 Oct 18, 2022
606df66
fix(): flip assignment
ShaMan123 Oct 18, 2022
cdc2c5e
goldens
ShaMan123 Oct 18, 2022
c1f21d1
revert(): svg stuff
ShaMan123 Oct 18, 2022
aa48a3b
cleanup
ShaMan123 Oct 18, 2022
4e84453
Update object.class.ts
ShaMan123 Oct 18, 2022
5ee4741
fix(): restore `compensateScaleForSkew`
ShaMan123 Oct 18, 2022
cf395b4
cleanup
ShaMan123 Oct 18, 2022
22abcc6
cleanup compensate
ShaMan123 Oct 18, 2022
3f4720a
rename
ShaMan123 Oct 18, 2022
dc482f5
WIP compensation
ShaMan123 Oct 18, 2022
fc70ee9
progress!
ShaMan123 Oct 18, 2022
6ec0e26
revert
ShaMan123 Oct 18, 2022
14c7713
refactor
ShaMan123 Oct 18, 2022
7f6e7a3
cleanup
ShaMan123 Oct 18, 2022
601c363
refactor(): axis keys
ShaMan123 Oct 19, 2022
f4f6635
refactor skew handlers
ShaMan123 Oct 19, 2022
040d459
minor fix + rename
ShaMan123 Oct 19, 2022
902a7ca
`compensationFactor` only for `skewY`
ShaMan123 Oct 19, 2022
4a28d67
fix(): anchoring origin
ShaMan123 Oct 20, 2022
7512123
rename for clarity
ShaMan123 Oct 20, 2022
6912a60
checkout unrelated changes
ShaMan123 Oct 20, 2022
51c63b4
Merge branch 'master' into fix-skewing-controls
ShaMan123 Oct 20, 2022
0d5d805
checkout svg visual tests/assets
ShaMan123 Oct 20, 2022
60dd440
Update controls.actions.ts
ShaMan123 Oct 20, 2022
cb72c5c
Merge branch 'master' into fix-skewing-controls
ShaMan123 Oct 26, 2022
3e67548
cleanup
ShaMan123 Oct 26, 2022
89d2c0b
fix(): skewing!!
ShaMan123 Oct 26, 2022
560f8d8
fix tests + add
ShaMan123 Oct 26, 2022
4db434b
account for scaling
ShaMan123 Oct 26, 2022
5491b5e
Update controls.actions.ts
ShaMan123 Oct 26, 2022
84b5bde
Update canvas.class.ts
ShaMan123 Oct 26, 2022
d17ec00
Update canvas.class.ts
ShaMan123 Oct 26, 2022
227381e
fix skewing on scaled object
ShaMan123 Oct 26, 2022
432a02b
Update controls_handlers.js
ShaMan123 Oct 26, 2022
bc4de25
Update controls.actions.ts
ShaMan123 Oct 26, 2022
ece8cc0
better explained
ShaMan123 Oct 27, 2022
f42a1e0
move `AXIS_KEYS`
ShaMan123 Oct 27, 2022
c603d85
fixes
ShaMan123 Oct 27, 2022
75b94fe
Update controls.actions.ts
ShaMan123 Oct 27, 2022
7248392
much better
ShaMan123 Oct 27, 2022
6888d8c
Merge branch 'master' into fix-skewing-controls
ShaMan123 Oct 27, 2022
0319b86
update resolveOrigin
ShaMan123 Oct 27, 2022
c1a519b
typo
ShaMan123 Oct 27, 2022
4066bf6
skewingSide
ShaMan123 Oct 27, 2022
e56d1f1
Update controls.actions.ts
ShaMan123 Oct 27, 2022
bc6e514
better comments
ShaMan123 Oct 27, 2022
6b11e11
pass down skewingSide
ShaMan123 Oct 27, 2022
7753d72
comments
ShaMan123 Oct 27, 2022
e68d0c2
distanceFromOrigin
ShaMan123 Oct 27, 2022
0f7a201
Update controls.actions.ts
ShaMan123 Oct 27, 2022
1a3146c
Update controls.actions.ts
ShaMan123 Oct 27, 2022
d9c5bd5
Update controls.actions.ts
ShaMan123 Oct 27, 2022
1ba2724
fix(): counter flip
ShaMan123 Oct 27, 2022
43a5657
fix
ShaMan123 Oct 27, 2022
91c5d72
Update buildStats.mjs
ShaMan123 Oct 27, 2022
f703f27
fix: flip
ShaMan123 Oct 28, 2022
21c4dd1
fix(): flipped
ShaMan123 Oct 28, 2022
7ba8f2e
Update controls.actions.ts
ShaMan123 Oct 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

## [next]

- chore(TS): Conver Geometry and Origin to classes/e6/ts [#8390](https://github.com/fabricjs/fabric.js/pull/8390)
- fix(): skewing controls accuracy + successive interactions [#8380](https://github.com/fabricjs/fabric.js/pull/8380)
- chore(TS): Convert Geometry and Origin to classes/e6/ts [#8390](https://github.com/fabricjs/fabric.js/pull/8390)
- ci(): build stats report [#8395](https://github.com/fabricjs/fabric.js/pull/8395)
- chore(TS): convert object to es6 class [#8322](https://github.com/fabricjs/fabric.js/pull/8322)
- docs(): guides follow up, feature request template [#8379](https://github.com/fabricjs/fabric.js/pull/8379)
Expand Down
4 changes: 2 additions & 2 deletions scripts/buildStats.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ export async function run({ github, context, a, b }) {
..._.map(files, ({ a, b }, key) => {
return [
key,
printSize(a.sizeBefore, b.sizeBefore),
printSize(a.sizeAfter, b.sizeAfter),
printSizeByte(a.sizeBefore, b.sizeBefore),
printSizeByte(a.sizeAfter, b.sizeAfter),
];
}),
];
Expand Down
3 changes: 2 additions & 1 deletion src/canvas.class.ts
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,8 @@ import { FabricObject } from './shapes/object.class';
lastX: pointer.x,
lastY: pointer.y,
theta: degreesToRadians(target.angle),
width: target.width * target.scaleX,
width: target.width,
height: target.height,
ShaMan123 marked this conversation as resolved.
Show resolved Hide resolved
shiftKey: e.shiftKey,
altKey: altKey,
original: fabric.util.saveObjectTransform(target),
Expand Down
Loading