-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task(IText): rename fabric-data
attr
#8292
Conversation
fabric-data
attrfabric-data
attr
@@ -16,7 +16,7 @@ import { config } from '../config'; | |||
this.hiddenTextarea.setAttribute('autocorrect', 'off'); | |||
this.hiddenTextarea.setAttribute('autocomplete', 'off'); | |||
this.hiddenTextarea.setAttribute('spellcheck', 'false'); | |||
this.hiddenTextarea.setAttribute('data-fabric-hiddentextarea', ''); | |||
this.hiddenTextarea.setAttribute('data-fabric', 'textarea'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have no much to say about this change, is neutral, but i want to point out a few things.
data-* does cover both data-fabric and data-fabric-attribute.
The assumed consistency gain is killed by the required change of code of whoever is using this.
This is really just a string, an identified, we can change it yes.
But i do think is a waste of energy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
point taken
I came across it by chance
I view it as something less to document
Need we can say "use the querySelector data-fabric
to get fabric elements", the value is one of...
I didn't think of the option data-fabric-*
...
commit 6a868f9 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 19:32:39 2022 +0300 ws fix commit e18d5c6 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 19:26:33 2022 +0300 rename + ws commit 7987763 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 19:20:56 2022 +0300 rename commit 00468ca Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 17:38:00 2022 +0300 Update group.js commit 2bb6551 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 17:37:53 2022 +0300 Update object.svg_export.ts commit c716e64 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 17:24:39 2022 +0300 ws commit 6b2e167 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 17:19:32 2022 +0300 Update object.svg_export.ts commit 83d3755 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 17:14:30 2022 +0300 imports commit 2c3ea4c Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 17:08:58 2022 +0300 cleaner impl commit a4a9013 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 16:47:46 2022 +0300 fix(): group svg export expose `createClipPathSVGMarkup` for group to override commit 6e21b15 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 09:45:07 2022 +0300 cleanup commit 3001858 Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 09:36:57 2022 +0300 fix(): group svg export commit 4b0130b Author: ShaMan123 <shacharnen@gmail.com> Date: Tue Sep 20 09:08:23 2022 +0300 Update object.svg_export.ts commit 44d7b0b Author: Andrea Bogazzi <andreabogazzi79@gmail.com> Date: Tue Sep 20 15:21:04 2022 +0200 Update CHANGELOG.md commit 4f481af Author: Shachar <34343793+ShaMan123@users.noreply.github.com> Date: Tue Sep 20 13:41:01 2022 +0300 ci(): add `build.lock` (#8290) commit e84f9a0 Author: Shachar <34343793+ShaMan123@users.noreply.github.com> Date: Tue Sep 20 06:25:26 2022 +0300 BREAKING: rename `data-fabric-hiddentextarea` to `data-fabric` (#8292) aligns with the rest of the data attribute usage commit f291945 Author: Shachar <34343793+ShaMan123@users.noreply.github.com> Date: Mon Sep 19 13:21:25 2022 +0300 fix(`WebGLProbe`): regression `enableGLFiltering` config + init bug (#8301) commit 71193d3 Author: Andrea Bogazzi <andreabogazzi79@gmail.com> Date: Mon Sep 19 08:35:26 2022 +0200 chore() Updating changelog (#8300) commit d77dc9b Author: Shachar <34343793+ShaMan123@users.noreply.github.com> Date: Mon Sep 19 01:55:39 2022 +0300 fix(fabric.utils) added missing import in dom_misc (#8293)
…cjs#8292) aligns with the rest of the data attribute usage
Align with the rest of HTML elements