docs(contributing): rework #8158

ShaMan123 · 2022-08-19T08:07:23Z

more concise and catching the eye

github-actions · 2022-08-19T08:09:36Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.55 |    84.4 |   80.64 |                                               
 fabric.js |   82.05 |    74.55 |    84.4 |   80.64 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T08:17:47Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.55 |    84.4 |   80.64 |                                               
 fabric.js |   82.05 |    74.55 |    84.4 |   80.64 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T08:19:42Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.04 |    74.52 |    84.4 |   80.63 |                                               
 fabric.js |   82.04 |    74.52 |    84.4 |   80.63 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T08:31:40Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.55 |    84.4 |   80.64 |                                               
 fabric.js |   82.05 |    74.55 |    84.4 |   80.64 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T08:34:06Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.55 |    84.4 |   80.64 |                                               
 fabric.js |   82.05 |    74.55 |    84.4 |   80.64 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T08:38:19Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.55 |    84.4 |   80.64 |                                               
 fabric.js |   82.05 |    74.55 |    84.4 |   80.64 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T08:40:47Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.55 |    84.4 |   80.64 |                                               
 fabric.js |   82.05 |    74.55 |    84.4 |   80.64 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123

I am happy with this
@asturur can you add the twitter missing links?

github-actions · 2022-08-19T08:41:44Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.1 |    74.58 |    84.4 |    80.7 |                                               
 fabric.js |    82.1 |    74.58 |    84.4 |    80.7 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T13:19:19Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.04 |    74.52 |    84.4 |   80.63 |                                               
 fabric.js |   82.04 |    74.52 |    84.4 |   80.63 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T13:20:54Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.04 |    74.52 |    84.4 |   80.63 |                                               
 fabric.js |   82.04 |    74.52 |    84.4 |   80.63 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T13:22:59Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.09 |    74.55 |    84.4 |   80.69 |                                               
 fabric.js |   82.09 |    74.55 |    84.4 |   80.69 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T13:25:48Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.1 |    74.58 |    84.4 |    80.7 |                                               
 fabric.js |    82.1 |    74.58 |    84.4 |    80.7 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T13:46:56Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.04 |    74.52 |    84.4 |   80.63 |                                               
 fabric.js |   82.04 |    74.52 |    84.4 |   80.63 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T13:49:28Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.55 |    84.4 |   80.64 |                                               
 fabric.js |   82.05 |    74.55 |    84.4 |   80.64 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T14:07:08Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.55 |    84.4 |   80.64 |                                               
 fabric.js |   82.05 |    74.55 |    84.4 |   80.64 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T14:09:11Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.04 |    74.52 |    84.4 |   80.63 |                                               
 fabric.js |   82.04 |    74.52 |    84.4 |   80.63 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

github-actions · 2022-08-19T14:19:23Z

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.55 |    84.4 |   80.64 |                                               
 fabric.js |   82.05 |    74.55 |    84.4 |   80.64 | ...,27456,27514,27524-27568,27676,27763,27967 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123 added 4 commits August 19, 2022 10:14

Update CONTRIBUTING.md

62784b7

Update CONTRIBUTING.md

1741b89

Update CONTRIBUTING.md

70081d0

Update CONTRIBUTING.md

c6af05f

ShaMan123 added 5 commits August 19, 2022 11:12

Update CONTRIBUTING.md

a4b83f2

Update CONTRIBUTING.md

0a17d5d

Update CONTRIBUTING.md

ea0adc7

Update CONTRIBUTING.md

a34ee6e

Update CONTRIBUTING.md

11e4383

Update CONTRIBUTING.md

de30f27

ShaMan123 added 3 commits August 19, 2022 11:20

Update CONTRIBUTING.md

e28ea11

Update CONTRIBUTING.md

de67978

Update CONTRIBUTING.md

36a7e66

ShaMan123 added 3 commits August 19, 2022 11:31

Update CONTRIBUTING.md

b2d5314

Update CONTRIBUTING.md

fc83f1f

Update CONTRIBUTING.md

1fbbfd3

ShaMan123 added 3 commits August 19, 2022 11:34

Update CONTRIBUTING.md

86fbbf7

Update CONTRIBUTING.md

633d8b4

Update CONTRIBUTING.md

1c476e9

ShaMan123 added 2 commits August 19, 2022 11:38

Update CONTRIBUTING.md

8d84ac6

Update CONTRIBUTING.md

15985b0

ShaMan123 commented Aug 19, 2022

View reviewed changes

ShaMan123 requested a review from asturur August 19, 2022 08:41

ShaMan123 added 2 commits August 19, 2022 16:16

Update CONTRIBUTING.md

596f243

Update CONTRIBUTING.md

0f828f4

Update CONTRIBUTING.md

d404699

Update CONTRIBUTING.md

e73f0aa

Update CONTRIBUTING.md

8e48a86

ShaMan123 added 4 commits August 19, 2022 16:26

Update CONTRIBUTING.md

8c30f38

Update CONTRIBUTING.md

d7a7925

Update CONTRIBUTING.md

bde0ff7

Update CONTRIBUTING.md

5eb1221

Update CONTRIBUTING.md

9a9eb6a

ShaMan123 added 2 commits August 19, 2022 17:04

Update CONTRIBUTING.md

b35c00f

Update CONTRIBUTING.md

63dd801

Update CONTRIBUTING.md

2bb0168

asturur approved these changes Aug 20, 2022

View reviewed changes

asturur merged commit 943ec5f into master Aug 20, 2022

ShaMan123 deleted the docs-contributing branch September 11, 2022 23:35

frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023

docs(contributing): rework (fabricjs#8158)

7483b98

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(contributing): rework #8158

docs(contributing): rework #8158

ShaMan123 commented Aug 19, 2022

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

ShaMan123 left a comment

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

docs(contributing): rework #8158

docs(contributing): rework #8158

Conversation

ShaMan123 commented Aug 19, 2022

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

ShaMan123 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 • edited Loading

Code Coverage Summary

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading

github-actions bot commented Aug 19, 2022 •

edited

Loading