Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): assigning canvas to collections #7934

Merged
merged 1 commit into from
May 14, 2022
Merged

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented May 12, 2022

Collections could be used as clip paths.
This PR fixes canvas assignment in such a case.
Because Group assigns canvas only if the property changed this should not affect performance.

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.05 |    75.98 |   85.69 |   82.78 |                                               
 fabric.js |   83.05 |    75.98 |   85.69 |   82.78 | ...,30850,30924,30935-31000,31123,31222,31458 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 changed the title fix(): assigning canvas for collections fix(): assigning canvas to collections May 13, 2022
@asturur
Copy link
Member

asturur commented May 14, 2022

The only thing we need to be careful of is determine what _set does and what set does.
Is fine to have one that is a bit higher level than another, important that is clear when to use one and another.

@ShaMan123
Copy link
Contributor Author

I assumed set is a simple wrapper that accepts objects to iterate over and pass down to _set.

@ShaMan123 ShaMan123 merged commit 23129ed into master May 14, 2022
@ShaMan123 ShaMan123 deleted the fix-assigning-canvas branch May 14, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants