Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(path): getRegularPolygonPath #7918

Merged
merged 5 commits into from
May 1, 2022
Merged

feat(path): getRegularPolygonPath #7918

merged 5 commits into from
May 1, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented May 1, 2022

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.92 |    75.84 |   85.64 |   82.65 |                                               
 fabric.js |   82.92 |    75.84 |   85.64 |   82.65 | ...,30871,30945,30956-31021,31144,31243,31479 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.93 |    75.87 |   85.64 |   82.66 |                                               
 fabric.js |   82.93 |    75.87 |   85.64 |   82.66 | ...,30871,30945,30956-31021,31144,31243,31479 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.95 |    75.89 |   85.64 |   82.68 |                                               
 fabric.js |   82.95 |    75.89 |   85.64 |   82.68 | ...,30866,30940,30951-31016,31139,31238,31474 
-----------|---------|----------|---------|---------|-----------------------------------------------

src/util/path.js Outdated Show resolved Hide resolved
@asturur
Copy link
Member

asturur commented May 1, 2022

I remember this function from that issue.
Can we add a simple test for 5 and 6 points to match a pre-defined string?
so that if the function gets changed the test needs to be updated and we can stop and think

@asturur asturur closed this May 1, 2022
@asturur asturur reopened this May 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.95 |    75.89 |   85.64 |   82.68 |                                               
 fabric.js |   82.95 |    75.89 |   85.64 |   82.68 | ...,30866,30940,30951-31016,31139,31238,31474 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.95 |    75.89 |   85.64 |   82.68 |                                               
 fabric.js |   82.95 |    75.89 |   85.64 |   82.68 | ...,30866,30940,30951-31016,31139,31238,31474 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.07 |    75.96 |   85.71 |   82.79 |                                               
 fabric.js |   83.07 |    75.96 |   85.71 |   82.79 | ...,30866,30940,30951-31016,31139,31238,31474 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 merged commit 02d560c into master May 1, 2022
@ShaMan123 ShaMan123 deleted the regular-polygon branch May 1, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RegularPolygon object type
2 participants