Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ActiveSelection): 🚀 multiple nested selection 🗂️ #7882

Closed
wants to merge 106 commits into from
Closed

fix(ActiveSelection): 🚀 multiple nested selection 🗂️ #7882

wants to merge 106 commits into from

Commits on Apr 3, 2022

  1. apply 7744 patch (no binaries)

    @ShaMan123
    ShaMan123 committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    1a191a7 View commit details
    Browse the repository at this point in the history

  2. apply 7744 patch (binaries)

    @ShaMan123
    ShaMan123 committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    26e8392 View commit details
    Browse the repository at this point in the history

  3. commit #7744 review 

    #7744 (review)
    @ShaMan123
    ShaMan123 committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    7d793b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. patch2

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    2708029 View commit details
    Browse the repository at this point in the history

  2. Update spray_brush.class.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    02a8ffa View commit details
    Browse the repository at this point in the history

  3. enable text editing under group

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    0d3690f View commit details
    Browse the repository at this point in the history

  4. migrate back to isDescendantOf

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    ff0346a View commit details
    Browse the repository at this point in the history

  5. render bg

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    812f02a View commit details
    Browse the repository at this point in the history

  6. fix(): clear canvas from entire object tree 

    in case object is a collection
    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    053946c View commit details
    Browse the repository at this point in the history

  7. fix(): center object in case object is nested

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    db76c44 View commit details
    Browse the repository at this point in the history

  8. Update eraser_brush.mixin.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    04aad5b View commit details
    Browse the repository at this point in the history

  9. Update canvas.class.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    8c1c535 View commit details
    Browse the repository at this point in the history

  10. Update canvas_events.mixin.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    3fd4af2 View commit details
    Browse the repository at this point in the history

  11. lint

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    58e9be2 View commit details
    Browse the repository at this point in the history

  12. safeguard from adding group to itself

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    c2ef2f5 View commit details
    Browse the repository at this point in the history

  13. Update object_ancestry.mixin.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    f0145b5 View commit details
    Browse the repository at this point in the history

  14. patch tests from v6!

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    cb20b81 View commit details
    Browse the repository at this point in the history

  15. Update canvas_grouping.mixin.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    347f80d View commit details
    Browse the repository at this point in the history

  16. Update canvas.class.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    a56d55e View commit details
    Browse the repository at this point in the history

  17. Update group_layout.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    2a426e7 View commit details
    Browse the repository at this point in the history

  18. Update group_layout.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    5e3fc1f View commit details
    Browse the repository at this point in the history

  19. remove redundant logic

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    2b1f680 View commit details
    Browse the repository at this point in the history

  20. Update canvas_grouping.mixin.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    1ad5cc8 View commit details
    Browse the repository at this point in the history

  21. fix(): calling sendPointToPlane

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    11c828f View commit details
    Browse the repository at this point in the history

  22. Update group.class.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    b6fa3dc View commit details
    Browse the repository at this point in the history

  23. refactor enterGroup

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    e9afc89 View commit details
    Browse the repository at this point in the history

  24. invalidate groups after active selection change

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    d8f8251 View commit details
    Browse the repository at this point in the history

  25. _shouldSetNestedCoords

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    c58a274 View commit details
    Browse the repository at this point in the history

  26. perf(): refrain from contains

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    c0f5571 View commit details
    Browse the repository at this point in the history

  27. Update canvas_events.mixin.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    9a223d0 View commit details
    Browse the repository at this point in the history

  28. Update canvas.class.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    2d5cc75 View commit details
    Browse the repository at this point in the history

  29. Update canvas.class.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    01c4a87 View commit details
    Browse the repository at this point in the history

  30. fix(): export svg backgroundColor

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    2164161 View commit details
    Browse the repository at this point in the history

  31. Update group.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    a5575bd View commit details
    Browse the repository at this point in the history

  32. backport collection fix to test

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    5c56124 View commit details
    Browse the repository at this point in the history

  33. Update group.class.js

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    5e3aaf5 View commit details
    Browse the repository at this point in the history

  34. lint

    @ShaMan123
    ShaMan123 committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    d53d6b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. fix(): target prop on canvas added/removed event

    @ShaMan123
    ShaMan123 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    8e907bb View commit details
    Browse the repository at this point in the history

  2. fix(): modify handlers strictly on canvas events

    @ShaMan123
    ShaMan123 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    f082fc9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into v6-group-patch2

    @ShaMan123
    ShaMan123 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    c2d93db View commit details
    Browse the repository at this point in the history

  4. Update group_layout.js

    @ShaMan123
    ShaMan123 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    2f346b0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into v6-group-patch2

    @ShaMan123
    ShaMan123 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    9931a3c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into v6-group-patch1

    @ShaMan123
    ShaMan123 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d6f1950 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'v6-group-patch1' into v6-group-patch2

    @ShaMan123
    ShaMan123 committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    5cb64af View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Merge branch 'master' into v6-group-patch2

    @asturur
    asturur authored Apr 7, 2022
    Configuration menu
    Copy the full SHA
    63cab25 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Update spray_brush.class.js

    @ShaMan123
    ShaMan123 committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    21110d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. remove merge error

    @ShaMan123
    ShaMan123 committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    6c141e1 View commit details
    Browse the repository at this point in the history

  2. add some comment

    @asturur
    asturur committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    465ea96 View commit details
    Browse the repository at this point in the history

  3. more comments

    @asturur
    asturur committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    ffafe66 View commit details
    Browse the repository at this point in the history

  4. only a comment and removed an extra negation by swapping a ternary

    @asturur
    asturur committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    e2d03f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. better invalidation + comment

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    3e09114 View commit details
    Browse the repository at this point in the history

  2. fix(): text enterEditing in interactive group

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    af3430c View commit details
    Browse the repository at this point in the history

  3. fix(): strict ancestors

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    67abe2f View commit details
    Browse the repository at this point in the history

  4. test findCommonAncestors

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    b8477f2 View commit details
    Browse the repository at this point in the history

  5. add strict option + fixes

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    d039d04 View commit details
    Browse the repository at this point in the history

  6. Revert "fix(): strict ancestors" 

    This reverts commit 67abe2f.
    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    2c49f67 View commit details
    Browse the repository at this point in the history

  7. fix test

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    7ba7fa4 View commit details
    Browse the repository at this point in the history

  8. better comments 

    isn't `Canvas#selection` meant for the group selector?
    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    de96660 View commit details
    Browse the repository at this point in the history

  9. better comment

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    b566158 View commit details
    Browse the repository at this point in the history

  10. JSDOC

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    beaa331 View commit details
    Browse the repository at this point in the history

  11. remove redundant len variable

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    c0aea33 View commit details
    Browse the repository at this point in the history

  12. fix(Collection): remove return value

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    3ec53b4 View commit details
    Browse the repository at this point in the history

  13. typo

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    1c414cf View commit details
    Browse the repository at this point in the history

  14. adjust tests

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    2c65a5c View commit details
    Browse the repository at this point in the history

  15. Update group.class.js

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    785433a View commit details
    Browse the repository at this point in the history

  16. Update collection.mixin.js

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    56a2b73 View commit details
    Browse the repository at this point in the history

  17. fix(): safegurad from circular refs

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    3df9435 View commit details
    Browse the repository at this point in the history

  18. Update group.js

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    d49baac View commit details
    Browse the repository at this point in the history

  19. Update group.js

    @ShaMan123
    ShaMan123 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    31d2107 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. refactor _chooseObjectsToRender

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    3f837ce View commit details
    Browse the repository at this point in the history

  2. fix(): _activeObjects

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    dd9f194 View commit details
    Browse the repository at this point in the history

  3. Update active_selection.class.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    014de45 View commit details
    Browse the repository at this point in the history

  4. fix(): render && preserveObjectStacking

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    9a48c10 View commit details
    Browse the repository at this point in the history

  5. Update group.class.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    51a454c View commit details
    Browse the repository at this point in the history

  6. preserve active selection ref

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    020c2bb View commit details
    Browse the repository at this point in the history

  7. fix(): propagate dirty up to owning group

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    6d0ed73 View commit details
    Browse the repository at this point in the history

  8. move

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    d18351f View commit details
    Browse the repository at this point in the history

  9. Update canvas.class.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    de46f45 View commit details
    Browse the repository at this point in the history

  10. Revert "move" 

    This reverts commit d18351f.
    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    a456afe View commit details
    Browse the repository at this point in the history

  11. fix(): remove redundant transform 

    might need this when calling
```js
new fabric.ActiveSelection(object)
```
if an object is parent of another group
    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    9214d8b View commit details
    Browse the repository at this point in the history

  12. test dirty propagation

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    9665b54 View commit details
    Browse the repository at this point in the history

  13. fix(): propagate dirty flag + preserveObjectStacking

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    fba43bd View commit details
    Browse the repository at this point in the history

  14. Update activeselection.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    8c095a3 View commit details
    Browse the repository at this point in the history

  15. Update activeselection.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    11da63b View commit details
    Browse the repository at this point in the history

  16. Update activeselection.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    6d5df90 View commit details
    Browse the repository at this point in the history

  17. fix(): _chooseObjectsToRender single active obj

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    8377693 View commit details
    Browse the repository at this point in the history

  18. safety

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    08f3c83 View commit details
    Browse the repository at this point in the history

  19. remove dead test

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    e23471c View commit details
    Browse the repository at this point in the history

  20. feat(): invalidate group + progress layout

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    b9a32d5 View commit details
    Browse the repository at this point in the history

  21. Update active_selection.class.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    dbc2e7d View commit details
    Browse the repository at this point in the history

  22. Revert "Update active_selection.class.js" 

    This reverts commit dbc2e7d.
    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    f34ccb3 View commit details
    Browse the repository at this point in the history

  23. disable progress layouts 

    too many edge cases and different use cases.
the dev can override themselves
    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    0fc26e3 View commit details
    Browse the repository at this point in the history

  24. Update group.class.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    f642a28 View commit details
    Browse the repository at this point in the history

  25. lint

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    2c78fb5 View commit details
    Browse the repository at this point in the history

  26. Update util.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    245a796 View commit details
    Browse the repository at this point in the history

  27. Update canvas_grouping.mixin.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    84c3345 View commit details
    Browse the repository at this point in the history

  28. Update object.class.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    79db7d5 View commit details
    Browse the repository at this point in the history

  29. add comment

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    24c279f View commit details
    Browse the repository at this point in the history

  30. tests

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    91232c8 View commit details
    Browse the repository at this point in the history

  31. Update group_layout.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    7b479ca View commit details
    Browse the repository at this point in the history

  32. Update group_layout.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    fc48a27 View commit details
    Browse the repository at this point in the history

  33. Update group_layout.js

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    9d77261 View commit details
    Browse the repository at this point in the history

  34. remove foul isCacheDirty

    @ShaMan123
    ShaMan123 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    5f3a39f View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. Merge branch 'master' into v6-nested-selection

    @ShaMan123
    ShaMan123 committed May 1, 2022
    Configuration menu
    Copy the full SHA
    864f174 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Merge branch 'master' into v6-nested-selection

    @ShaMan123
    ShaMan123 committed May 2, 2022
    Configuration menu
    Copy the full SHA
    8c317fe View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Merge branch 'master' into v6-nested-selection

    @ShaMan123
    ShaMan123 committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    91a7f53 View commit details
    Browse the repository at this point in the history